Add a loop/replay button

TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.

https://newpipe.net

GNU General Public License v3.0

31.81k stars 3.09k forks source link

Add a loop/replay button #8647

Open theridon opened 2 years ago

theridon commented 2 years ago

Checklist

[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I have read and understood the contribution guidelines.

Feature description

This app has just about everything else, it's great. But for some reason there is no replay/loop button/functionality? Can we just get a simple button below the video that would let it replay videos, such as for listening to music in a car? Thank you.

Why do you want this feature?

So the app is better

Additional information

No response

SameenAhnaf commented 2 years ago

Rejected. See: https://github.com/TeamNewPipe/NewPipe/issues/6914

However, you can still use this functionality from notification player. Go to Settings>Appearence>Player Notification>4th/ 5th Action Button> Select Repeat

theridon commented 2 years ago

I disable notifications from my apps, so I can't use that feature. Plus it's quite inconvenient to have to drag down the notification bar for such a basic, integral feature. Can we just get a button that's usable when normally using the app?

opusforlife2 commented 2 years ago

I disable notifications from my apps

In version 0.20.0, Newpipe's player was rewritten and made wholly dependent on a unified player service, which needs a foreground notification to anchor it in memory.

I don't think we support use cases where notifications for the app are disabled. But I'll let a developer weigh in on this.

triallax commented 2 years ago

I wholeheartedly agree that it doesn't make sense for the looping functionality to be present only in the media notification, not the app itself. It's quite inconvenient. Like I stated in https://github.com/TeamNewPipe/NewPipe/issues/6914#issuecomment-899027896, adding a loop button in the player would be a good idea in my opinion.

Stypox commented 2 years ago

I don't think we support use cases where notifications for the app are disabled. But I'll let a developer weigh in on this.

Foreground apps work just fine if you disable their notifications ;-)

opusforlife2 commented 2 years ago

I agree with Stypox's solution in https://github.com/TeamNewPipe/NewPipe/issues/6914#issuecomment-1190142193.

opusforlife2 commented 1 year ago

This is something that should be considered for the rewrite.