TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.02k stars 3.02k forks source link

Can't open YT url from browser in app #8654

Open victorKH opened 2 years ago

victorKH commented 2 years ago

Checklist

Affected version

0.23.1 (bug not present in 0.23.0)

Steps to reproduce the bug

1.Open in opera mini web-page with youtube video

  1. Click on play button on video or just on video
  2. See new page like "vnd.youtube:CoFjiEDELF8" or standard android app chooser for url processing. But in 0.23.0 was NewPipe's "open" action dialog.

Expected behavior

In 0.23.0 version when open url video its shows NewPipe's "open" action dialog (I use "Always ask" setting).

Actual behavior

In 0.23.1 its starts android standard chooser for selecting app to download (process url) where NewPipe not present.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 4.4.4 / OmniRom

Affected device model

Samsung Tab P1000

Additional information

Please return previous behavior or add NewPipe to android app chooser for url processing.

I use also Opera mini (version 7.7 and 20.x, latest versions has built-in youtube player/downloader that often not work) which produce url in format like vnd.youtube:CoFjiEDELF8 which not recognized by NewPipe (but youtube standard client starts video normally before dropping android 4.4 support) Such url can be used by NewPipe after manual transformation to youtube.com/watch?v=CoFjiEDELF8

Please add support for this urls.

P.S. sorry for my english. Hope you understand info.

SC1040-TS2 commented 2 years ago

The English is fine, but this issue reminds me of an unrelated one that was just discovered when troubleshooting a connectivity hang on my own phone, a Samsung Galaxy S9 running stock Android 10.

In this case, the app suffered a connectivity problem while in the middle of playing a video and was unable to resolve a strange URL during playback, which in this case was "rr3---sn-hp57yns7.googlevideo.com" due to not finding an address associated with that hostname. This was corroborated in the form of checking the googlevideo.com site, which redirected to a Google.com homepage with custom parameters of www.google.com/webhp?tbm=vid&gws_rd=ssl .

It is obviously an unrelated issue to the above, but the idea of the app or extractor having legacy code or sometimes digesting or failing to digest video URLs that have old, no longer supported, or otherwise odd formats leading to crashes and playback issues both prior to and after version 0.23.1 may be a consistent theme.

opusforlife2 commented 2 years ago

@victorKH Try associating Newpipe with all its supported URLs again from system settings.

victorKH commented 2 years ago

All associations are default. I uninstall 0.23.0, then install 0.23.1 - so its clean installation.

opusforlife2 commented 2 years ago

@victorKH That is precisely the action which makes an app lose all associations, so you need to manually make them again. Did you try this in Settings?

victorKH commented 2 years ago

I delete 0.23.1, install 0.23.0 - 'open' action dialog appear - then UPGRADE to 0.23.1 (visible to user settings migrated successfully) - 'open' action dialog don't appear when clicking on video in browser. In changes log I see some manipulations with resources (styles and strings) - this dialog has some theme problem (partial theme implemented): so I think problem with: maybe silent crash (error catches and exit without inform user), maybe some manifest changes or etc. Backing to 0.23.0 not a way to solve issue because NewPipe don't recognize links like vnd.youtube:CoFjiEDELF8 (see my issue description).