While in full-screen, pressing the back button sometimes goes to the previous video, in addition to leaving the full screen

stdedos commented 2 years ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.23.1

Steps to reproduce the bug

Open a video in full screen
Move to the next video
maybe: don't wait for the video to start playing
Press the back button to leave full screen

Expected behavior

Full screen is dismissed

Actual behavior

Previous video starts playing

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

S8

Additional information

On top of https://github.com/TeamNewPipe/NewPipe/issues/8658

opusforlife2 commented 2 years ago

maybe: don't wait for the video to start playing

Try this a bunch of times and see if that "maybe" turns into a "definitely".

stdedos commented 2 years ago

Steps to reproduce the bug

Open a video in full screen

Move to the end screens 2.5. Notice that the fullscreen was stopped, and you have "NP portrait" in landscape mode

Press the next video to play

Before the video loads, press the back button "to leave full screen" (i.e. switch to landscape)

Consistent repro

Monirzadeh commented 2 months ago

it happen when you play a new video without closing or finish previous video. if first video close than back functionality work correctly. is it possible to fix that? relay annoying

TeamNewPipe / NewPipe