Notifications of the same videos keep being generated

Kroesss commented 2 years ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.23.1

Steps to reproduce the bug

Dismiss notification of video from subscribed channel
Mark the video as watched
Receive notifications of the same video over and over again.

Expected behavior

I expect just 1 notification of a new video from a subscribed channel. This should not return after it has been dismissed.

Actual behavior

I keep getting notifications of the same videos for months. I have marked them as watched, I have swiped the notifications away and I have tapped the notifications multiple times. A couple times per week I get the same notifications back.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 11 (stock OEM-version of OnePlus)

Affected device model

OnePlus Nord2 5G

Additional information

No response

daykx commented 2 years ago

Maybe it's related: after downloading a video and dismissing notification about downloading it, sometimes download notification repeats several hours later.

theg721 commented 1 year ago

I've had the same issue for a while now. One thing I've noticed is that there are specific channels this happens with. It doesn't happen for most of the channels I'm subscribed to, but for example both Tom Scott and Tom Scott Plus seem to consistently have this issue.

I think marking the latest video watched is irrelevant as I've had this both on videos I have watched and videos I haven't watched.

paulverbeke commented 10 months ago

It's been happening to me for a while too. Now for every new push I receive 20+ that I need to swipe away. OnePlus 8T stock OS Android 13 OnePlus 8T Pixel Experience Android 13 Newpipe 0.26.0

TobiGr commented 10 months ago

Uh, I thought that this was fixed by #10494. Please export your database via settings > content > export database and send it to team{at]newpipe.net. I do not have much time now, so I cannot promise a deep analysis - maybe it's an obvious bug when looking at the data. Please also name the videos / channels that are effected by the bug in the email.

paulverbeke commented 10 months ago

Ok thanks I'll send you all this by mail as soon as it happen's again

paulverbeke commented 10 months ago

All right just sent you an email with 2 screenshots, the exported database, and name of channels and links of videos for easier testing. I can see that all the videos I checked were from 3 months ago. I think it's always these same videos that are pushed again to me in a loop

paulverbeke commented 10 months ago

Just received your answer by mail.

You said you've done this to reproduce unsuccessfully:

Install NewPipe 0.26.1
Import your database (backup from the 28th)
(Tons of notifications appear)
Close new notifications
wait for new notifications
only three channels show up with videos from within the last hour

I don't know what else to say. NewPipe is 0.26.1 but it just happened to me again this morning (but only with some videos not all of them). Just in case, I made a new backup (on the 29th), cleared app data to reset the app, and made some tests: Re-importing the db of the 28th --> I receive 4 push. Re-importing the db of the 29th --> I don't receive any push. So maybe you're right, the old videos may have finally been cleared from the db.

Thanks for the investigation, will let you posted here

Kroesss commented 10 months ago

Same here. I am also on 0.26.1, and got notifications of old video's this morning.

opusforlife2 commented 10 months ago

So maybe you're right, the old videos may have finally been cleared from the db.

Let's wait a little longer to confirm this.

rx78gp01 commented 10 months ago

I also got notifications of old video that video's upload date between 3 and 4 months ago. It seems that NewPipeExtractor extract wrong video's upload date between 3 and 4 months ago, newpipe show textual date 2 months ago in feed.

paulverbeke commented 10 months ago

So maybe you're right, the old videos may have finally been cleared from the db.

Let's wait a little longer to confirm this.

Just received this push the 2nd of January https://www.youtube.com/watch?v=cBpGq-vDr2Y. Released 29th sept 2023

And received this one (https://www.youtube.com/watch?v=xILlbJzwuRc) the 3rd of January, released 3rd October 2023.

Kroesss commented 6 months ago

Is this bug still being worked on? To be honest, it is becoming rather annoying getting 10 notifications every day about old video's

opusforlife2 commented 6 months ago

Someone will have to investigate this more deeply. It doesn't happen to any of the team members so it's hard to debug.

As an experiment, you could try this:

Export your database so you have a backup when you're done testing. (Or you could use a Release Candidate APK from the pinned issue right now so your main app isn't disturbed.)
Export your subscriptions from the Subscriptions tab.
Clear Newpipe data from App Info.
Open Newpipe and import only Subscriptions.
Set up your notifications how you want them.
See if the problem occurs again.

If it doesn't, that would mean your database got corrupted somehow.

Kroesss commented 6 months ago

Is there some kind of log or anything that I should capture first, just in case?

I did install the new update today, so I am on 0.27 now

opusforlife2 commented 6 months ago

If the steps above work, we can at least narrow it down to a database corruption. Try that first.

Kroesss commented 6 months ago

@opusforlife2 I've done the steps you indicated yesterday, and woke up to old notifications today sadly.

What is the best thing for me to do now?

paulverbeke commented 6 months ago

@opusforlife2 It still happens to me, I'll try the experiment you suggested.

opusforlife2 commented 6 months ago

@Kroesss What happened when you tried the steps? Did the problem occur?

Kroesss commented 6 months ago

@opusforlife2 Yes. Sorry, now that I re-read my comment it is a bit vague.

I did the steps you mentioned, and the next morning when I woke up, I had 10 notifications of old video's. I got them again this morning by the way, so the behaviour is consistent.

As mentioned, I am running 0.27, so the latest version.

opusforlife2 commented 6 months ago

If @paulverbeke gets the same results, then it's likely not a database corruption but something else. Let's see.

paulverbeke commented 6 months ago

Could it be possible that importing the database fixes it, but gets corrupted again over time ?

paulverbeke commented 6 months ago

All right, done the same thing you instructed and received 6 push today, all from the 1st may. So looks like it's working.

opusforlife2 commented 6 months ago

Let's wait for a while to see if the behaviour is consistent.

Kroesss commented 6 months ago

For what it is worth, I got the old notifications again today. No changes in settings.

opusforlife2 commented 6 months ago

Could you try the exact steps once more, @Kroesss? The fact that you're both getting different results via the same steps is pointing towards different problems. Paul's might be a corrupt database after all, and yours might be something else. So let's confirm once more.

paulverbeke commented 6 months ago

Since yesterday the bug occurs again sorry 😔

opusforlife2 commented 6 months ago

Welp. Then it's something else, not a corrupt database.

Kroesss commented 6 months ago

If I can help by supplying logs or test something, just let me know.

sivaraam commented 5 months ago

For the note, I also followed the steps listed here and was able to still observe the redundant notifications issue.

TeamNewPipe / NewPipe