Visual Bug: Player Notification Thumbnail and Colorization only displaying in certain cases.

SC1040-TS2 commented 1 year ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.24.0

Steps to reproduce the bug

Have the Appearance, Player Notificatien settings set to Enable Colorize Notification and Show Thumbnail.
Open any video.
Change the resolution to anything other than the Best/Highest Resolution. This will cause the aforementioned Player Notification settings to break.

Expected behavior

The Thumbnail Preview image and Colorized Notification are retained regardless of playback resolution changes.

Actual behavior

Changing the resolution breaks these Player Notification features for an example video. It only resolves when a new video is loaded, and can still be replicated for any videos using the above steps.

Screenshots/Screen recordings

The video and notification at Best Resolution.

The video and notification after lowering the resolution.

Logs

N/A.

Affected Android/Custom ROM version

Android 10.0, One UI 2.5, Kernel version 4.9.186-22990479

Affected device model

Samsung Galaxy S9.

Additional information

All animations on the device are disabled, but that never broke this functionality in prior app versions.

This appears to be a lasting effect of this app version's recent refactoring of how thumbnail previews are handled, in now being vectorized.

Closing the Player Notification and restarting playback of the same video also temporarily resolves this, but only so long as the resolution is not changed.

SC1040-TS2 commented 1 year ago

Okay, @opusforlife2 , some more discoveries on this were made.

Any time a given video is played for the first time following its selection, be it the Video Player, Background Player, or Popup Player, the Player notification works normally.

The breakage of the thumbnail preview and colorization occurs on ANY subsequent playbacks of the selected video. It does not just include resolution changes; even switching the player preferences from whichever is the first selected one will break these features. For example, selecting the Background player and then deciding to use the Video player induces breakage.

Only closing the Player Notification or the Show Info/Video Player window and performing another first-time selection and playback mitigates this.

AudricV commented 1 year ago

Thanks for posting this issue that I found very soon after the release, but for which I didn't have time to report it.

Here is a screen recording showing steps which happen in the player and are the origin of this issue:

https://user-images.githubusercontent.com/74829229/198855834-8fb0c1a1-ae91-4599-8217-0316b5bf1021.mp4

TeamNewPipe / NewPipe