TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.41k stars 3.06k forks source link

[YouTube] Channel handles url does not work without @ prefix. #9436

Open Cryptophunk opened 1 year ago

Cryptophunk commented 1 year ago

Checklist

Affected version

0.24.1

Steps to reproduce the bug

  1. In Firefox (not chrome as it wants you to use/install the YouTube app to open in-app) go to a channel that has a channel handle but remove the @ prefix. For example https://www.youtube.com/CharlieSolis
  2. If you have Newpipe configured to open up YouTube associated links automatically you can confirm it works by adding the @ prefix eg https://www.youtube.com/@CharlieSolis

Expected behavior

Newpipe should launch to the respected channel page associated with the url. It does not do this behaviour without adding the @ prefix.

Actual behavior

App does not respond.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 10

Affected device model

All Models

Additional information

No response

Cryptophunk commented 1 year ago

@opusforlife2 isn't this a bug because the pull request "[YouTube] Support handles and all channel usernames #964" indicates that all channel usernames and handles are now supported?

opusforlife2 commented 1 year ago

It doesn't matter what a pull request says. Since this isn't part of the current release (0.24.1) and it makes no claim to support handles, this is a new feature that is being perfected. You could have 10 PRs which add support for a feature in small chunks, and sometimes break and fix things in the process as well.

Cryptophunk commented 1 year ago

@opusforlife2 are you sure you checked to make sure that this was included in 0.24.1? In the blog post for this update it says this: "@AudricV added support for YouTube handles. This refers to channel links starting with ‘@’. Also, more kinds of usernames are supported now."

It also mentions this new feature in the release notes for 0.24.1

opusforlife2 commented 1 year ago

You're right, my bad. I thought the PR was merged after the release.

Cryptophunk commented 1 year ago

I don't have an environment set up to test this but would adding <data android:pathPrefix="/" /> under line 156 found here fix the issue? Maybe this is something @AudricV can answer and test for me. Thanks so much in advance!