Touch and hold to activate seekbar.

jcperil commented 1 year ago

Checklist

[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I have read and understood the contribution guidelines.

Feature description

Touch the video player and hold to activate the seekbar. Then you can perform usual seekbar actions like swipe left or right to seek any time stamp.

I don't have any video illustration but I recall that this feature can be observed in YouTube (Revanced).

Why do you want this feature?

The seekbar line is very thin and I agree it should be. One has to precisely touch the line to activate the seekbar which is kind of uneasy for my fingers. Adding this feature would help a lot.

Also, the seekbar stays hidden during playback and appears only if you touch somewhere on the player. It's not annoying but it's one extra step.

Additional information

SameenAhnaf commented 1 year ago

Are you asking for https://github.com/TeamNewPipe/NewPipe/issues/6271?

jcperil commented 1 year ago

No. In #6271, user starts by touching the seekbar and performs swipe actions. Also, it is about some speed related issue.

I would start by long pressing anywhere on the screen. That's what I meant by touch and hold. This should activate the seekbar, i.e. allow you to slide left or right to seek. I just discovered that this feature is available on the official YouTube Android client too.

https://user-images.githubusercontent.com/89805719/205655044-34fe98d6-bc63-4340-a8cf-a6f72de726f0.mp4

SameenAhnaf commented 1 year ago

@jcperil What about https://github.com/TeamNewPipe/NewPipe/issues/889? Is that extra long press gesture required?

jcperil commented 1 year ago

I wouldn't consider it a duplicate of #889 if that's what you are infering. Please find here another illustration of my request around 1:20 timestamp.

Are you asking which way of "slide to seek" would I prefer? Implementing #889 would mean the seekbar is always active and has a chance of seeking left or right accidentally while touching the screen, or cleaning something on screen for instance. That's why I would prefer to long press (this would activate the seekbar as illustrated above) and only then slide to seek.

That's just my opinion. I am aware that #889 is a feature on VLC media player's Android client but to overcome accidental seeking, VLC also implemented a feature to lock the screen while watching. Then you have to unlock the media player if you would like to seek left/right again.

SameenAhnaf commented 1 year ago

I never said that this is a duplicate. What I am saying is that we don't need two separate gestures Long Press+Swipe & Swipe for the same action.

Anyway, I am closing that issue.

opusforlife2 commented 1 year ago

I proposed another solution here: https://github.com/TeamNewPipe/NewPipe/issues/6363#issuecomment-847923356

jcperil commented 1 year ago

This is nice too. May I ask something?

I am aware that what I am requesting is particularly a feature of YouTube's official client. If NewPipe implements it, will there be any legal issues with YouTube?

opusforlife2 commented 1 year ago

We use Exoplayer, an open source library provided by Google. If we modify how we use it, that's still following the license, since we will publish the changes.

If you're worried that we're copying a feature from YT... well, this entire app, and several others, wouldn't exist. xD

jcperil commented 1 year ago

That's a good point haha. I was just being sure. Sorry about that silly question.

MD77MD commented 1 year ago

I wouldn't consider it a duplicate of #889 if that's what you are infering. Please find here another illustration of my request around 1:20 timestamp.

Are you asking which way of "slide to seek" would I prefer? Implementing #889 would mean the seekbar is always active and has a chance of seeking left or right accidentally while touching the screen, or cleaning something on screen for instance. That's why I would prefer to long press (this would activate the seekbar as illustrated above) and only then slide to seek.

That's just my opinion. I am aware that #889 is a feature on VLC media player's Android client but to overcome accidental seeking, VLC also implemented a feature to lock the screen while watching. Then you have to unlock the media player if you would like to seek left/right again.

Honestly this is really unnecessary, what about accidental vertical swips which is in both sides... VLC implementation is not used by everyone for nothing, its because It's the right balance and it works... If you're really worried about accidental gestures Then you should be asking for a lock screen feature to use like i do, especially in long Watching sessions, a movie for example.

moreover when using swipe gesture, It is very rare to land on the right place from first time... usually it would take 2 to 3 attempt before landing on the right scene... So imagine doing a the long press swipe for each time

jcperil commented 1 year ago

I would like to clarify that this is a request for long press+slide to seek and not direct swipe to seek like VLC. Any arguments against direct swiping should be directed towards #889.

VLC implementation is not used by everyone for nothing, its because It's the right balance and it works...

Popularity is not really a strong argument, is it?! I could say the same thing about YouTube's implementation of long press+slide to seek feature.

If you're really worried about accidental gestures Then you should be asking for a lock screen feature to use like i do, especially in long Watching sessions, a movie for example.

Horizontal accidental gestures will occur if direct horizontal swiping is implemented. But it isn't implemented. Long press+swipe solves this issue but before you intervene, that is not why I requested it. In case you missed,

The seekbar line is very thin and I agree it should be. One has to precisely touch the line to activate the seekbar which is kind of uneasy for my fingers. Adding this feature would help a lot.

If you are worried about vertical accidental swiping, please open a new issue recommending an alternative.

moreover when using swipe gesture, It is very rare to land on the right place from first time... usually it would take 2 to 3 attempt before landing on the right scene... So imagine doing a the long press swipe for each time

This is not the case with YouTube's implementation of long press+slide because the time stamps are shown in real time while you are swiping. So, if you want to jump to 3 min 20 sec, you stop sliding till you reach 3 min 20 sec.

MD77MD commented 1 year ago

ok I'm Convinced. thank you for the explanation 😊

Robin-Sch commented 1 year ago

Kinda related to https://github.com/TeamNewPipe/NewPipe/issues/6363, same issue, just different solution(s)

MD77MD commented 1 year ago

Kinda related to #6363, same issue, just different solution(s)

no... they are completely different and we need both... one is talking about a bug and how to solve it... and the other is requesting a feature

TeamNewPipe / NewPipe