TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.24k stars 3.03k forks source link

[UI Enhancement] - Double tap should be animated #9682

Closed ccuser44 closed 1 year ago

ccuser44 commented 1 year ago

Checklist

Feature description

On NewPipe you can forward the video by double tapping. This displays three arrows pointing and shows the amount of time being skipped and it has a black circle in the background appear.

In the regular Youtube app this Circle is animated via a ripple effect. There are several ways this animation could (in my opinion) be added to newpipe (choose the one which is best for newpipe):

Why do you want this feature?

When this is not animated it looks very visually unappealing and clunky, it sticks out a lot. If it would be animated it would look so much better. This is a very small change but it would improve the app experience a lot by making is smoother.

Additional information

See the normal Youtube app for reference.

opusforlife2 commented 1 year ago

The current animation was changed to be different from Youtube's. We considered the visibility of the video underlying the animation to be more important. Hence the animation's effects were toned down. Moreover, Newpipe still runs on very old devices, so the animation also had to be simple enough that those devices wouldn't suffer.

ccuser44 commented 1 year ago

The current animation was changed to be different from Youtube's. We considered the visibility of the video underlying the animation to be more important. Hence the animation's effects were toned down. Moreover, Newpipe still runs on very old devices, so the animation also had to be simple enough that those devices wouldn't suffer.

Thats understandable. Maybe the transparency of thw backround circle could be tweened which wouldnt be as obstructive and as performance intensive than a riplle effect?

opusforlife2 commented 1 year ago

Are you able to provide a video example? It's difficult to visualise.

ccuser44 commented 1 year ago

Are you able to provide a video example? It's difficult to visualise.

I mean, if you can't add a ripple effect to the circle, could it be possible if you tweened the transparency of the circle instead? From Invisible -> Visible -> Invisible

opusforlife2 commented 1 year ago

I have no idea what that means. Maybe a developer could have a look.

ccuser44 commented 1 year ago

I have no idea what that means. Maybe a developer could have a look.

What I mean is:

Both of these would be less performance intensive than the ripple effect that youtube has

ccuser44 commented 1 year ago

Apparently this is done so I'm closing this as completed

opusforlife2 commented 1 year ago

That's weird. There has been no change to the animation at all. Are you sure your device settings haven't been reset or something?