TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.57k stars 3.07k forks source link

Dark theme uses light themed icons #9803

Open illerokcob opened 1 year ago

illerokcob commented 1 year ago

Checklist

Affected version

0.25.0

Steps to reproduce the bug

Hard to reproduce, usually occurs when navigating between activities (example: home screen -> search -> video).

Expected behavior

The app would use white coloured icons when dark theme is applied.

Actual behavior

The following icons are changed to their dark themed version while the app is using dark theme and the bug is present:

In order to achieve normal behavior again, recreating the base activity is needed (force stopping or killing the app is not necessary).

Icons on the Action Bar/App Bar and inside the player window behave correctly.

Screenshots/Screen recordings

Screenshot_20230212-171312_NewPipe_1
Screenshot_20230212-171404_NewPipe_1
Screenshot_20230212-171415_NewPipe_1
Screenshot_20230212-171521_NewPipe_1
Screenshot_20230212-171744_NewPipe_1

Logs

No response

Affected Android/Custom ROM version

LineageOS 18.1

Affected device model

No response

Additional information

The bug has occured on version 0.24.1 a few times as well.

SameenAhnaf commented 1 year ago

I think, I figured out the exact steps.

  1. Search any video.
  2. Add it to a newly created playlist.
  3. Reload feed.

https://github.com/TeamNewPipe/NewPipe/assets/79245641/27804053-2657-4223-b45c-0e97492ab7a2