TeamNewPipe / NewPipeExtractor

NewPipe's core library for extracting data from streaming sites
GNU General Public License v3.0
1.4k stars 421 forks source link

Always return whatever YouTube provides when filtering search #1146

Open Stypox opened 11 months ago

Stypox commented 11 months ago

https://github.com/TeamNewPipe/NewPipeExtractor/blob/9ab932e394f31a6687014d69d241dc1a56e4ee18/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeSearchExtractor.java#L236-L245

This snippet comes from YouTube search extractor's collectStreamsFrom. At the moment we are using these boolean values to only return the requested type of items (e.g. channels) even if YouTube provides some other unrequested item types (e.g. the channel's videos).

In my opinion the extractor should be transparent to such inconsistencies, and just return whatever YouTube provides. Basically, in my opinion b71ce1123f5e3a99f3e4287d10565c0489c840df should be reverted. What do you think @FireMasterK @AudricV?