[YouTube] Add trending position to StreamInfoItem

TeamNewPipe / NewPipeExtractor

NewPipe's core library for extracting data from streaming sites

GNU General Public License v3.0

1.4k stars 420 forks source link

[YouTube] Add trending position to StreamInfoItem #1149

Closed FineFindus closed 10 months ago

FineFindus commented 10 months ago

[x] I carefully read the contribution guidelines and agree to them.
[ ] I have tested the API against NewPipe.
[ ] I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Adds support for getting the trending position of the video, e.g. #16 on Trending. Image showing the trending tag of a video

AudricV commented 10 months ago

Sorry, but unless there is an approach which allows getting this data from the stream items directly, we will not accept this PR, as we cannot fetch HTML pages or video metadata responses for each stream in a stream list, due to resources consumption and the increase of chances to flag the IP used by the extractor as an abusive one (which would result for instance to captchas and/or IP bans on videoplayback and/or InnerTube player endpoint).

FineFindus commented 10 months ago

Well, that's sad to hear :(, but understandable. This is unfortunately the only occurrence of this data on the website, it's not sent in another API response. This may be different for other platforms, but I haven't looked into extracting data from them yet. If someone finds a better way to get the data, I'll be happy to work on it again. Closing it for now.