TeamNewPipe / NewPipeExtractor

NewPipe's core library for extracting data from streaming sites
GNU General Public License v3.0
1.39k stars 419 forks source link

[Bandcamp] Null-safe url catenation in track playlist #1200

Closed fynngodau closed 4 months ago

fynngodau commented 4 months ago

Previously, if no URL was provided due to the track being a preorder or unpaid track that doesn't have its own public page, we would catenate the artist URL and null to a nonsensical string.

This invalid URL would also be used to try fetching a thumbnail URL.

The downstream behavior of the NewPipe client is only marginally improved, as it now no longer throws visible exceptions due to the missing thumbnails, but still gives an unfriendly error upon clicking the item that has a null URL.

Resolves https://github.com/TeamNewPipe/NewPipeExtractor/issues/1154, and also resolves a discussion in https://github.com/TeamNewPipe/NewPipeExtractor/pull/1033#discussion_r1156465180.