Refactored Identifiers - Githubissues

TeamNewPipe / NewPipeExtractor

NewPipe's core library for extracting data from streaming sites

GNU General Public License v3.0

1.4k stars 420 forks source link

Refactored Identifiers #1205

Closed congyuluo closed 1 week ago

congyuluo commented 3 months ago

Refactored several identifiers in the code for better coherence to the variable/identifier's usage in the code.

[x] I carefully read the contribution guidelines and agree to them.
[x] I have tested the API against NewPipe.
[x] I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

[!IMPORTANT]

Breaking changes

Stream.equalStats(Stream) is renamed to Stream.areStatsEqual(Stream) Stream.getBitrate() is renamed to Stream.getBitRate()

Stypox commented 1 week ago

I am sorry, but after discussing with the team we decided to revert this Pull Request as we would rather avoid breaking changes. Thank you anyway!