TeamNewPipe / NewPlayer

GNU General Public License v3.0
105 stars 6 forks source link

Ghost taps in video player UI #3

Open theScrabi opened 1 month ago

theScrabi commented 1 month ago

When an animation is going on, apparently compose only transforms or alters the pixels of the drawn elements. It does not change the hit boxes. Therefore, you can tap on elements that are visually not there anymore or are visually at a different location.

You can find this at different places but here is an example to reproduce:

  1. Play a video and go to fullscreen mode
  2. Open the chapters screen
  3. Close the chapter screen
  4. Immediately after closing tap somewhere in the middle of the screen. (The hiding animation of the chapters select screen must still go on).

What happens:

To the eye it looks like the chapter select screen is not visible anymore. However, by quickly taping in the middle of the screen while the chapter select screen hiding animation is still going on you were still able to select a different chapter.

What should happen:

The mentioned behavior is irritating. Since NewPipe is WISWIG. You can not see the select screen. Instead, you can see either the blank video or the video controller UI. Because of this either the video controller or the touch ui should get the input. Not the hiding chapter UI.

Keep in mind that this issue is just an example. You can find a similar behavior when the video controller UI hides or when the playlist select screen hides.

theScrabi commented 3 weeks ago

I temporarily fixed this issue but disabling the animations here and here.

theScrabi commented 3 weeks ago

This stackoverflow thread here might lead to a solution: https://stackoverflow.com/questions/73443804/how-can-one-composibles-clicks-pass-through-to-a-composible-underneath