TeamOpenIndustry / ImmersiveRailroading

GNU Lesser General Public License v2.1
226 stars 72 forks source link

Unable to enter train at random times which causes players to lose items, and possible desync on servers #1090

Open DemonOrca95 opened 3 years ago

DemonOrca95 commented 3 years ago

Describe the bug:

Sometimes on random occasions, or disconnecting and reconnecting to a server, you are unable to re-enter a train. Attempting to do so will misplace items in your inventory, and has a high risk of deleting any armors the player is wearing. This will also duplicate random items in said player inventory when trying to either board, or access a locomotive by shift-clicking it.

Additionally, tracks might have invisible, full-sized blocks where they're present, so you can't walk on top of them anymore unless you jump. And trying to ride on a freight car or accessing its inventory may cause your game to crash.

The only way this bug stops is if you completely close your game/modpack and reload it, then all is temporarily back to normal upon rejoining the server.

There's also a bad deysync, where one player can be driving a train, and another player in the same area will either not see it move, or the train will look distorted on their screen, even if the one driving doesn't see that happening. Sometimes other players can't properly board a train somebody else is running.

How to reproduce:

Steps to reproduce the unwanted behavior: Run a server with IR on 1.7.10, run a train with several cars on it for a bit, then disconnect from server, and reconnect without closing the game, then try accessing your train.

For the desync, have another player standing close by and run a train past them. Maybe have that same player try getting riding that same train if it has a passenger car.

Optionally, if more information is needed on this bug, or you want to see the full extent of it, download this exported Modpack, import it on CurseForge, and test it on a server. This link contains the full modpack, but heads up: It may take a bit to download. https://drive.google.com/drive/folders/1MMyOadUC7dvT0SNqkMRm_FrBRBc8sVxb?usp=sharing

Expected behavior:

Can't enter train, entering a train may misplace items in inventory, delete armor, entering freight cars might crash the game, tracks will suddenly be made of fully solid invisible blocks, and desyncs if other players are present.

System Information:

OS: Windows
Allocated Memory: [The memory allocated to your Minecraft instance where you encountered the bug e.g. "7gb"]
IR-Version: [e.g. "1.9.1_1.7.10"]
Forge-Version: [e.g. "1.7.10 - 10.13.4.1614"]

Modlist:
Avaritia Binnie's Mods Buildcraft Buildcraft Compat CodeChickenCore CraftTweaker Custom NPCs ExtraCells2 Fast Craft Magic Bees Mine Together Nuclear Control 2 Open Mods Lib Open Drawers Thaumic Energistics The Twilight Forest Traincraft Advanced Solar pin AgriCraft Another One Bites the Dust Applied Energistics 2 Archimedes' Ships ASP + GS Patcher BdLib BiblioCraft Big Reactors BinniePatcher BiomeTweaker Blood Magic Botania Brandon's Core Carpenter's Blocks Chisel CoFH Core CoFH Lib ComputerCraft Cooking for Blockheads Custom Main Menu Custom Mob Spawner CustomThings Decocraft Draconic Evolution Ender IO Ender Storage Ender Core Ender Tech Ex Astris Ex Compressum Ex Nihilo Extra Utilities Extra TiC Fast Leaf Decay Forbidden Magic Forestry FoxLib FTB Islands FTB Library (Forge) (Legacy) FTB Utilities (Forge) FTBTrophies Funky Locomotion Gendustry Gravitation Suite 1.7.10 Guide-API Hardcore Questing Mode iChunUtil Iguanas Tinker Tweaks Immersive Engineering Immersive Integration Immersive Railroading Industrial Craft2 INpureCore Inventory Tweaks Iron Chests Jabba JourneyMap KleeSlabs Lockdown Logistics Pipes Mantle McJtyLib Mercurius Minefactory Reloaded Mo' Creatures ModTweaker Morph Morpheus NEI Addons NEI Integration NotEnoughItems OpenBlocks OpenPeripheralAddons OpenPeripheralCore OpenPeripheralIntegration Pam's HarvestCraft Project Red Compat Project Red - Core Project Red - Expansion Project Red - Exploration Project Red - Illumination Project Red - Integration Railcraft Redstone Arsenal Resource Loader RFTools Simply Jetpacks Solar Expansion Steve's Carts 2 Storage Drawers: Biomes O' Plenty Storage Drawers: Forestry Pack Storage Drawers: Misc Pack Storage Drawers: Natura Pack Tails Thaumcraft Thaumcraft NEI Plugin Thaumic Exploration Thaumic Inventory Scanning (Thaumcraft Addon) Thermal Dynamics Thermal Expansion Thermal Foundation TiC Tooltips Tinkers Construct Tinkers' Mechworks Universal Mod Core Walia Waila Harvestability Wawla - What Are We Looking At Witchery WorldEdit WR-CBE-Universal YUNoMakeGoodMap

Additional context
I've noticed that other people are experiencing similar, if not the same issue on 1.7.10, with at least one guy reporting a duplication bug as an additional problem.

This bug makes IR really unplayable on servers since players run the risk of losing precious items when attempting to use it, especially for those in survival mode.

quentfr21 commented 3 years ago

same for me on 1.7.10 server i notice it work fine until you pass in another dimension after you need to restar the game entirely but all machine are not working good even if you just launch the game