search

TeamOpenIndustry / ImmersiveRailroading

GNU Lesser General Public License v2.1
224 stars 72 forks source link

EXTERNAL_DOOR_X can't work properly on higher versions #1488

Open Goldenfield192 opened 3 months ago

Goldenfield192 commented 3 months ago

Describe the bug
On higher versions Minecraft, like 1.14.4&1.16.5, players can't get off the train from external doors and will be teleported to the centre of the stock when attempting to enter the stock via external door.

How to reproduce
1.Place a stock which has external doors and open it 2.Enter it 3.Try to get off through it

Expected behavior
External doors should telepert the player to its position in the stock and can be used to exit, like 1.12.2.

System Information
OS: Windows
System Memory: 24GB
Allocated Memory: 24GB
CPU: AMD 5600G
GPU: Vega 7
IR-Version: 1.10 of corresponding Minecraft version
Forge-Version: 1.14.4-28.2.26; 1.16.5-36.2.42

Modlist
UMC 1.2.1 of corresponding version IR 1.10 of corresponding version

Goldenfield192 commented 2 months ago

In 1.12.2 for client and server side EntityRidableRollingStock$getMountOffset returns almost the same vector, but in 1.14.4 it returns correct value for server side but always return (0,y,0) for client side It seems that IR uses the client value which causes the bug I speculate that it appears in all versions above 1.14