Closed omg-xtao closed 2 years ago
Merging this PR leaves code quality unchanged.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 64.77 ⛔ | 64.77 ⛔ | 0.00 |
Method Length | 280.50 ⛔ | 280.50 ⛔ | 0.00 |
Working memory | 20.35 ⛔ | 20.35 ⛔ | 0.00 |
Quality | 14.55% ⛔ | 14.55% ⛔ | 0.00% |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 669 | 669 | 0 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
pagermaid/init.py | 50.51% 🙂 | 50.51% 🙂 | 0.00% |
pagermaid/listener.py | 10.79% ⛔ | 10.79% ⛔ | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
pagermaid/listener.py | listener | 124 ⛔ | 925 ⛔ | 22 ⛔ | 3.09% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
pagermaid/listener.py | listener.decorator | 57 ⛔ | 436 ⛔ | 21 ⛔ | 6.58% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
pagermaid/listener.py | listener.decorator.handler | 32 😞 | 376 ⛔ | 21 ⛔ | 13.74% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
pagermaid/listener.py | raw_listener | 43 ⛔ | 259 ⛔ | 20 ⛔ | 13.92% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
pagermaid/listener.py | raw_listener.decorator | 30 😞 | 253 ⛔ | 20 ⛔ | 18.97% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Description
Please carefully read the Contributing note and Code of conduct before making any pull requests. And, Do not make a pull request to merge into master unless it is a hotfix. Use the development branch instead.
Issues fixed by this PR
Type of changes
Checklist: