Closed godlikeanyone closed 2 years ago
✅ Merging this PR will increase code quality in the affected files by 0.16%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 4.15 ⭐ | 4.09 ⭐ | -0.06 👍 |
Method Length | 109.45 🙂 | 109.09 🙂 | -0.36 👍 |
Working memory | 8.22 🙂 | 8.20 🙂 | -0.02 👍 |
Quality | 63.16% 🙂 | 63.32% 🙂 | 0.16% 👍 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 203 | 202 | -1 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
pagermaid/modules/status.py | 63.16% 🙂 | 63.32% 🙂 | 0.16% 👍 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
pagermaid/modules/status.py | stats | 7 ⭐ | 172 😞 | 15 😞 | 45.97% 😞 | Try splitting into smaller methods. Extract out complex expressions |
pagermaid/modules/status.py | ping_dc | 12 🙂 | 161 😞 | 11 😞 | 48.39% 😞 | Try splitting into smaller methods. Extract out complex expressions |
pagermaid/modules/status.py | neofetch_win | 1 ⭐ | 132 😞 | 19 ⛔ | 52.31% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
pagermaid/modules/status.py | status | 4 ⭐ | 207 ⛔ | 56.27% 🙂 | Try splitting into smaller methods | |
pagermaid/modules/status.py | get_uptime | 6 ⭐ | 129 😞 | 64.42% 🙂 | Try splitting into smaller methods |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Do not make a pull request to merge into master unless it is a hotfix.
Remove unnecessary code :)
Description
Please carefully read the Contributing note and Code of conduct before making any pull requests. And, Do not make a pull request to merge into master unless it is a hotfix. Use the development branch instead.
Issues fixed by this PR
Type of changes
Checklist: