search

TeamPiped / Piped

An alternative privacy-friendly YouTube frontend which is efficient by design.
https://piped.video
GNU Affero General Public License v3.0
8.49k stars 700 forks source link

Make links in Comments sections clickable like a hyperlink. #1244

Closed IkelAtomig closed 6 months ago

ManeraKai commented 2 years ago

We had a problem in LibRedirect where if you right click and open link on a text youtube link, it will bypass it the same way it'll do when pressing the Watch on YouTube button as the origin is from a piped instance. A fix for that would be to do it like invidious. They remove the domain name from youtube urls and make it as such: image

IkelAtomig commented 2 years ago

I would like this issue to be reopened. I think the URL should be made like Invidious like @ManeraKai suggested.

This request is made because it escapes Libredirect's redirect function and also users might find this frustating both Libredirect and Piped cuz going to YT instead of Piped isn't liked by many.

@Bnyro - What's your opinion and take on this ?

IkelAtomig commented 2 years ago

Any updates ?

opusforlife2 commented 6 months ago

@Bnyro Why did you close your PR? Is this infeasible? Redlib and Nitter (RIP) could both do this.

Bnyro commented 6 months ago

No idea to be honest, it's already been almost 2 years ago 🤷

opusforlife2 commented 6 months ago

Mind taking a fresh look then? 🤭

Bnyro commented 6 months ago

This should already be working properly looking at https://github.com/TeamPiped/Piped/blob/master/src/utils/HtmlUtils.js. Any example video where it doesn't? @opusforlife2

opusforlife2 commented 6 months ago

Wow, this task was surprisingly difficult. Stumbled upon this somehow: https://piped.video/watch?v=jmEC8rkE0Sk

opusforlife2 commented 6 months ago

Awesome. Thanks!