TeamPiped / Piped

An alternative privacy-friendly YouTube frontend which is efficient by design.
https://piped.video
GNU Affero General Public License v3.0
8.19k stars 664 forks source link

Resolution: "Auto" option should reflect current playback video resolution #1448

Open goodness-from-me opened 1 year ago

goodness-from-me commented 1 year ago

Describe the feature

I have set up 2160p as my default resolution in Preferences. But during video playback, no matter what video I play, "Resolution" option in the sub menu always displays "Auto" which is not informative. It would be useful to display current video resolution, something like "Auto (2160p)".

Why would this be useful to add?

It is useful to know which video resolution is being played, especially if "Auto" option is selected.

Concept(s)

I imagine it to be something like this: image

First of all, it should reflect the mode selected (Auto), and also the current resolution (2160p). If manual mode is selected it should just show selected resolution.

Additional context

No response

Acknowledgements

opusforlife2 commented 1 year ago

Just came across this. To add another layer of ambiguity, if you switch from Auto to the resolution you've set as your default, the player seems to load it afresh instead of doing nothing, so you're never sure if your default resolution was actually playing.

foxjaw commented 10 months ago

The issue of author is not about the default resolution. It's about the lack of information of what "auto" actually is. What resolution is the video is in right now ? It shows me "auto". So, which res is it set to ?

ac615223s5 commented 1 month ago

This happens because the the video stream is not among the list of streams in the resolution list. There are multiple streams with the same resolution, but only one is in the list. The streams in the resolution list have lower audio quality than the stream that gets automatically selected.

https://github.com/shaka-project/shaka-player/blob/ffbceb8fc0b8288b9ca233db2f4143cd7a1a83e3/ui/resolution_selection.js#L123

1055