Better sponsorblock API support

bonswouar commented 1 year ago

Describe the feature

I'm not sure if this is in the spirit of this neat project, but I'd love to have a more complete sponsorblock integration. I mainly had some community-oriented features in mind:

Save & submit new segments
Downvote/upvote segments
Set sponsportblock apikey in preferences

And that could be completed with smaller ui/ux tweaks :

Display more details than a bar color (for those who don't remember the colors :))
894 and other improvements maybe ?

Why would this be useful to add?

I'm sure lots of Piped users would like to participate to improve sponsorblock content!

Concept(s)

Basically get closer to the original Sponsorblock browser extension :)

Additional context

No response

Acknowledgements

[X] I have searched the existing issues and this is NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this form.

FireMasterK commented 1 year ago

PRs accepted! I won't be working on this feature.

bonswouar commented 1 year ago

I could definitely try to implement something like that, although the UX/UI part isn't really my cup of tea :sweat_smile:

bonswouar commented 1 year ago

@FireMasterK I might need few hints on how it should be implemented. I see sponsorblock requests use the custom sponsorblock mirror, so I'll add some new api routes for new actions, no problem on that. But how should I pass the user's API key, ie just using the current routes but adding an api_key parameter or something more sophisticated/secured?

FireMasterK commented 1 year ago

Ideally, I want this to be done without any requests to the backend. It should be generated clientside and should communicate with sponsor.ajay.app directly.

bonswouar commented 1 year ago

Do I understand correctly, it means getting rid of current sponsorblock proxy, all sponsorblock calls will be made directly from the client to the official (or a custom one) api? If so, sounds good to me! :)

FireMasterK commented 1 year ago

No, we're going to keep the sponsorblock proxy, but that would just be for fetching data from it.

Apart from that, everything else seems fine.

TeamPiped / Piped