Open opusforlife2 opened 1 month ago
Imo it's reasonable enough to capture home and end keys, that's been added with https://github.com/TeamPiped/Piped/pull/3664 and should be the expected behavior.
That PR has no description or sample video so I can't tell how it uses these keys.
Anyway, I think the main idea here is that when the focus is with the player, it's expected that certain keys will have overrides to act as shortcuts for various player functions.
However, when the player loses focus, the keys should go back to performing functions expected of them for the rest of the webpage.
I agree with OP. I have lost my position in videos when pressing home key while being deep into reading comments to go back up - it's not intuitive to capture home and end keys at all times in my opinion.
I added it because it is the behaviour on youtube but I don't mind either way. Also, it's related to #3136.
I vaguely remember back when I used Youtube that it had pretty wacky behaviour. This might have been one of those things.
Official Instance
Describe the bug
Along with Pg Up and Pg Dn, the Home and End keys can be used to jump scroll pages. However, on Piped, the latter 2 keys are captured by the player, and instead of jumping to the page top and bottom, they jump to the video beginning and end.
To Reproduce
Expected behavior
The player should not capture the Home and End keys.
Logs/Errors
No response
Browser, and OS with Version.
Firefox 128, W10.
Additional context
No response