TeamPneumatic / pnc-repressurized

A port of PneumaticCraft to MC1.12+
Other
122 stars 49 forks source link

Pressure chamber constantly leaking air when at 0.50 bar or higher #1079

Open Nevrai opened 2 years ago

Nevrai commented 2 years ago

Describe the bug

The pressure chamber starts leaking air from within it, filling the room and any nearby rooms with pressurized air, after it hits a certain point of pressure—exactly 0.50/5 bar. Adding a few volume upgrades makes it stop because the pressure goes down, until it hits 0.50 bar again, at which point it keeps leaking air seemingly forever until it gets below 0.50 bar.

Even when the pressure chamber is working properly and has no errors, it’s still leaking air, even though it’s able to still function and compress items. I tried turning off the air compressors, but it’s still leaking air. I tried with and without a security upgrade, but it makes no difference. I also tried restarting the game, but that didn’t help either. I’m not sure whether I’m possibly doing something wrong, or if this is a bug, but from what I can tell from my searching and asking for help, this isn’t supposed to happen, and unless I’m mistaken, I set everything up correctly. I’m new to PneumaticCraft: Repressurized, and this has been happening since I started with the pressure chamber.

There is no hissing sound, or any sound at all, and there are no leaks from any of the pipes. I originally hadpressure chamber five valves on the top. I replaced them with shorter tubing to three valves on the side. I originally had four and then five air compressors and then added five more, with a total of ten. I also tried breaking all the tubes and replacing them, as well as breaking part of the pressure chamber and re-placing the blocks. Nothing seems to make any difference, and the pressure chamber is still leaking pressurized air from within it constantly when above 0.50/5 bar. The air compressors, pressure chamber, and pressure chamber interfaces are not having any errors. This happened when I had no items in the chamber but also when I did have items in the chamber. As mentioned, it still seems to function properly, producing compressed iron ingots from iron ingots or compressed iron blocks from iron blocks, but it’s constantly showing this pressurized air leaking effect, which is frustrating, and I’m not sure whether it’s affecting the pressure chamber or not, but it does seem like this is a bug from what I can tell.

The entire pressure chamber, tubes, chest and hopper, and air compressors are within a single chunk, except two of the air compressors and tubes. However, as mentioned, I did try turning them all off, but the pressure chamber keeps leaking air from within, as shown in the screenshot below. The chunks are chunk-loaded.

I tried removing the everything that was out of the chunk. The pressure chamber, air compressors, tubes, chests, and hopper are all in a single chunk. The same issue happens. Over 0.50 bar and it immediately starts releasing a bunch of air everywhere. It doesn’t seem to have an effect on gameplay from what I can tell, but I’m not exactly sure. It doesn’t seem to lose its pressure. It’s just frustrating as you are barely able to see anything.

2022-08-30_09 12 53

How to reproduce the bug

Create a pressure chamber and use multiple valves with pressure tubes connected to them from air compressors. Watch the air leak constantly from within, or at least appear to, when the chamber’s pressure level is at 0.50 or higher.

Expected behavior

The pressure chamber shouldn’t leak air when no tube or valve leaks are present.

Versions

Nevrai commented 2 years ago

Tested it out in an instance with only PneumaticCraft: Repressurized, Rubidium, and Oculus installed, where the same issue occured (with shaders enabled). Confirmed that this is an issue with Oculus + shaders. Disabling shaders makes the pressure chamber only display what I assume to be the default pressurized air particles, which only show up within the chamber and aren’t obtrusive at all. So this is most likely an issue on Oculus’ end. I’ve also experienced other rendering issues with Oculus, significantly impacting the rendering of certain things in Botania, Tinkers’ Construct, and Mekanism.

I’ve reported this to Oculus’ issue tracker here.

Feel free to close this issue. I’m not sure if you want to take a look at it, as I don’t know whether this could be an issue with PneumaticCraft: Pressurized somehow, or if it could be fixed on its end, but I’m assuming this bug is on Oculus’ side.

Nevrai commented 2 years ago

Huh, back in my world, this is still happening even when I deactivate the shaders. This is very strange. It may not be a shaders issue, but I suppose it could still be an Oculus issue, as it’s still installed. It’s just odd that this issue stopped happening when I turned off shaders in the test world with only the aforementioned mods installed and then started happening again with shaders toggled on again, but in my world in All the Mods 7 (+ some mods added such as Rubidium and Oculus), this happens regardless of whether shaders are enabled.

2022-08-30_11 24 17

Maybe you can take a look at this? I’m not sure what’s going on.

desht commented 2 years ago

Particles start appearing at 0.5 bar, so this is fairly clearly a case of Rubidium and/or Oculus interfering with how particles are rendered. It's definitely not a leak, but purely a clientside rendering issue.

There isn't really anything I can (or wish to) do about what rendering optimisation mods mess up, so this is on them.

Nevrai commented 2 years ago

@desht This doesn’t seem like something that’s going to be fixed on Oculus’ end. Is there any way you could add a config option to PneumaticCraft: Repressurized’s client config to disable the pressurized air particles that appear in the chamber when it’s above 0.5 bar (but not affect the ones that appear when there’s an air leak)? That way, it’d be possible to use this mod with Oculus installed without the room constantly being filled with this white steam effect. I know this is a problem with Oculus, but if you could add a client-side option to disable the air particles inside the chamber, that would be fantastic!

desht commented 2 years ago

I guess it would be pretty easy to add a client side config seeing for that yeah...

Nevrai commented 2 years ago

Yay! Would be super appreciated. That way I can still play with PneumaticCraft: RP without being blinded :p Would be a nice workaround.

Nevrai commented 2 years ago

Thank you so much for adding that config option! I can finally play with PneumaticCraft without being blinded with buggy Oculus rendering. Much appreciated!

2022-09-01_12 35 47

Vectrobe commented 9 months ago

yea I found out that this affects all of the air particle rendering specifically with this mod, it occurs with the tubes as well and with oculus disabled, so whats happening is probably the scale not being set correctly during the render process, the values are probably carried over from previous rendering but due to optimisations in other mods this can result in the values not being what's desired, and the particles end up being rendered about 10-100 times larger.

Vectrobe commented 9 months ago

I can see in AirParticle how it uses the vanilla rendering and it uses scale(1.1) each tick, however I do not currently have a dev setup to check what initial values are on particle spawn

Vectrobe commented 9 months ago

apparently in my current instance its specifically create steam'n'rails that causes the missscaling, odd

Vectrobe commented 9 months ago

moved to #1274 for clarity