search

TeamPneumatic / pnc-repressurized

A port of PneumaticCraft to MC1.12+
Other
119 stars 47 forks source link

TPP has comparator output even though it can't do work #1256

Open johalun opened 7 months ago

johalun commented 7 months ago

Describe the bug

As discussed on Discord. The TPP should act like the Refinery when it comes to comparator output. If for any reason it can't do work, there should be no signal output. However, with for example ethanol production the TPP gives comparator output even thought the output tank is full.

How to reproduce the bug

Place down a TPP with redstone comparator taking output from it. Fill it up with yeast, sugar and ethanol.

Expected behavior

The comparator should not give redstone signal if the TPP output tank is full with ethanol

Additional details

No response

Which Minecraft version are you using?

1.19

Which version of PneumaticCraft: Repressurized are you using?

1.19.2-4.3.9

Crash log

No response

desht commented 7 months ago

Yeah right now the TPP just checks for a valid recipe. A better "has work" check would also check for valid input materials and space in the output.