search

TeamPneumatic / pnc-repressurized

A port of PneumaticCraft to MC1.12+
Other
119 stars 47 forks source link

[1.20.1] Air particle size conflict with other mods #1274

Open Vectrobe opened 6 months ago

Vectrobe commented 6 months ago

Describe the bug

With some other mods a conflict occurs with the scaling of air particles, when other mods change the scale of the same type of vanilla particle for their own renderers, the current example is with create:steam'n'rails that uses this for large smoke particles.

https://github.com/Layers-of-Railways/Railway/issues/357

Screenshot_24 Screenshot_23

How to reproduce the bug

Create a simple instance with the latest 1.20.1 neoforge, pneumaticraft and create + steam'n'rails. Make an empty flat world. Make a simple pnc pressure chamber and venting tube comming from a creative compressor set at 4.5bar. Observe the particles will be the wrong size, but then if you exit and disable steam'n'rails and check again, the particles will be normal

Expected behavior

Particles should remain normally sized regardless of other mods, manually setting the scale value should be sufficient in theory?

Additional details

No response

Which Minecraft version are you using?

1.20

Which version of PneumaticCraft: Repressurized are you using?

6.0.12

Crash log

No response

Vectrobe commented 6 months ago

https://github.com/Layers-of-Railways/Railway/issues/357

Vectrobe commented 6 months ago

additional unexpected behavior is if oculus and a shader are enabled, the particles are scaled correctly, so oculus has its own workaround specifically for shaders