Drone death does not respect Curse of Vanishing

[bartico6]

Describe the bug

When a drone using curse of vanishing items is killed, it drops them on death as opposed to voiding them. This means base defense setups in PvP, where you want to deny strong weapons your drones are using to players who manage to take them down would not work - as vanishing items would not, well, vanish,

How to reproduce the bug

Give a drone a curse of vanishing weapon, get it to equip it (such as via an entity attack command) then kill it.

Expected behavior

The drone doesn't drop the item with curse of vanishing on it upon death.

Additional details

No response

Which Minecraft version are you using?

1.20.1

Which version of PneumaticCraft: Repressurized are you using?

6.0.17

Crash log

No response

[bartico6]

Late addition, but for convenience sake, it should be differentiated between wrench "kills" (dismantling) and every other kill type - it might make sense (or maybe not? worth discussing balance-wise) to only let drones drop their vanish-cursed items if they're dismantled, but not when killed.

[desht]

I guess the intention is to allow you, the drone owner, to retrieve those vanishing items if you need to wrench a drone for reprogramming purposes etc? Which kinda makes sense, as long as the items only drop if the drone is wrenched by the owning player...

[bartico6]

I guess the intention is to allow you, the drone owner, to retrieve those vanishing items if you need to wrench a drone for reprogramming purposes etc? Which kinda makes sense, as long as the items only drop if the drone is wrenched by the owning player...

Yep, that's exactly right - and appreciate the swift fix <3

[desht]

Keeping this open for now, till a release is done

[desht]

Fixed in 8.2.0 for 1.21.1, will get 1.20.1 release out soon