Dig puzzle piece ignores Glowstone

[duncanwebb]

Minecraft Version

1.16.4

Forge Version

35.1.13

Mod Version

pneumaticcraft-repressurized-1.16.4-2.8.1-96

Describe your problem, including steps to reproduce it

Quarrying with the program controller the dig piece ignores glowstone. There are no blacklisted items in the big piece.

[duncanwebb]

There might be something else. With 35 inventory upgrades in the PC shouldn't the stored fluid amount be more than 16 buckets?

[duncanwebb]

With the speed upgrades and void excess this is what happens and the video is the same as in https://github.com/TeamPneumatic/pnc-repressurized/issues/692#issuecomment-753505428.

Top video is build 109 and bottom one is build 104. I prefer the behaviour of build 104 but like the speed that build 109 processes empty layers and voiding off the excess.

Sorry for all the trouble, I should have realized earlier that it was lack of speed upgrades that was causing the problem.

https://user-images.githubusercontent.com/4198031/103463718-b5458a80-4d2e-11eb-9e75-58b67bcf1bf1.mp4

https://user-images.githubusercontent.com/4198031/103463918-423d1380-4d30-11eb-967e-584a1a7ed161.mp4

[desht]

Yeah, thinking the new autosort thing is possibly a mistake. As long as the tank doesn't fill, we're probably good. I'll have another play with it tomorrow though.

[desht]

Build 110 backs the re-sorting disabling that I added. It does mess up the drone's iteration order, and you're right that's it better without it.

Also, try debugging the programmable controller with this build :) And let me know if you can break it, the code is very new and only lightly tested so far.

[duncanwebb]

Note the tank's volume in mB is 16000 + 16000 * inv_upgrades if you want to test for fullness.

Don't think this is the case, otherwise the tank wouldn't have filled up so quickly.

I'll test this new build today and many thanks for debugging feature, I'll check this too, and it will be a real help.

Maybe you can change the "can't reproduce" label as you figured out what the original problem was.

[desht]

I think you're right: the fluid tank isn't taking inventory upgrades into account. It should really work the same drones, i.e. using the formula I gave above.

Actually, the code does update the tank's capacity according to the installed upgrades... I'll need to test this and see what's up.

Update: found the problem, will be fixed in next build/release.

[desht]

On the topic of releases, I plan to get a 2.9.0 release out very soon. Would you say all the problems in this issue are resolved at this point? This is the only one holding up a release now...

[duncanwebb]

We can't see the capacity of the tank, but it does look like the capacity is 16 buckets.

Debugger looking excellent

[desht]

We can't see the capacity of the tank, but it does look like the capacity is 16 buckets.

It is. Problem is a bug where the PC ignores inventory upgrades (for tank sizing purposes) on world reload. If you take the inv upgrades out and put them back right now, it will increase the tank size... until the next world reload, anyway.

[duncanwebb]

The behaviour of the mini-drone is now excellent it minded correctly even with lava flowing above it. And I see replacing the upgrades does increase the tank - that would be a tricky bug to find.

[desht]

Fixed in 2.9.0 release