search

TeamPorcupine / ProjectPorcupine

Project Porcupine: A Base-Building Game...in Space!
GNU General Public License v3.0
483 stars 280 forks source link

Proposed PR convention for changing the scene #520

Closed kd7uiy closed 7 years ago

kd7uiy commented 7 years ago

Let's make it really obvious when there's a PR that changes the scene. Why? The scene doesn't merge well, and as a result any change to it could cause serious issues. So this should be specifically called out in the PR request, so that if someone wants to make a change to the scene, they can look to see if there's already a PR in relation to it.

Let's just put [SCENE] at the beginning of any title for a PR that changes the scene.

chismar commented 7 years ago

We probably instead of this should decompose the scene into more modular parts, so anyone who want's to add UI, for example, would need to create a new scene, and it will be loaded additively.

kd7uiy commented 7 years ago

I'm not really sure how to do drag and drop scenes. I suppose we could set it all up with prefabs maybe, and that would reduce the need to edit the scene somewhat? Just edit the prefab, not the entire scene, unless you are doing something to the entire scene?

chismar commented 7 years ago

Create a new scene - add your UI. Store its name in a specified folder. From the main scene search that folder and call LoadLevelAdditive for each of scene-names you found.

Or we could just use AssetBundles.

kd7uiy commented 7 years ago

Okay then, let's use this issue to decide how to organize everything. Most of the Scene is UI, so more organization than that is required.

vogonistic commented 7 years ago

We've merged a PR that removes most controllers from the scene today (#407). I think that's the right path. Load as much as possible through code, including the UI (#537).

Both of these actually help us with modding and testing inside Unity.

sboigelot commented 7 years ago

As most SCENE modification are now done via code, we can probably close this issue.