TeamPyOgg / PyOgg

Simple OGG Vorbis, Opus and FLAC bindings for Python
The Unlicense
64 stars 27 forks source link

A typo found as well as my suggestion for style #8

Closed zhengwx11 closed 6 years ago

zhengwx11 commented 6 years ago

In File library_loader.py at Line 33, there is a variable called paths written as pahts, which results in uncaught name xxx not defined exception.

Note that such typo should be caught by exception. However, it is simply dropped in File ogg.py at Line 58.

Please at least print out exceptions rather than drop them.

zhengwx11 commented 6 years ago

My bad. It seems like the pip image is older than your git repo.

Zuzu-Typ commented 6 years ago

It was fixed in version 0.6.3a1 . Please try running pip install pyogg --upgrade

I will however change the way it handles exceptions shortly. Thank you for your suggestion :)