TeamREPENTOGON / REPENTOGON

Script extender for The Binding of Isaac: Repentance
https://repentogon.com/
GNU General Public License v2.0
115 stars 11 forks source link

Current Artifacts crash at Runtime #446

Closed BreavyTF2 closed 2 months ago

BreavyTF2 commented 2 months ago

Artifacts compiled after this commit crash after startup once REPENTOGON has initialized. When mods are enabled a runtime error message occurs, while if mods are instead disabled it just crashes to desktop. The only info within the log before the error is this: "[INFO] - Lua stack trace: [INFO] - Caught exception, writing minidump..." image

BreavyTF2 commented 2 months ago

forgot to attach the log files. repentogon.log zhl.log dsound.log

jsgnextortex commented 2 months ago

Could you provide your normal repentance log?, also, if you happen to have the dmp file it can also help a ton.

BreavyTF2 commented 2 months ago

isaacv1.7.9b.J835-20240511-015218-97476-103596.dmp isaacv1.7.9b.J835-20240511-015218-97476-103596.txt

DMP file and the base log file.

im-tem commented 2 months ago

I assume the crash happens during the file map generation as no entries past that are visible in the log, will shove in more logging and generate a build in the next couple of hours

im-tem commented 2 months ago

Do you have a mods folder in your Isaac directory? I was able to get a very similar crash by renaming that folder

im-tem commented 2 months ago

the crash has happened because the mod amount was zero and i used an unsigned integer to iterate over the mods in reverse order @BreavyTF2 can you try the next artifact? (https://github.com/TeamREPENTOGON/REPENTOGON/actions/runs/9042298611)

BreavyTF2 commented 2 months ago

Runs properly now if mods are disabled. Still crashes when certain mods are enabled.

the crash has happened because the mod amount was zero and i used an unsigned integer to iterate over the mods in reverse order @BreavyTF2 can you try the next artifact? (https://github.com/TeamREPENTOGON/REPENTOGON/actions/runs/9042298611)

im-tem commented 2 months ago

can you give examples of such mods?

BreavyTF2 commented 2 months ago

https://steamcommunity.com/sharedfiles/filedetails/?id=2808882244 This didn't crash before https://github.com/TeamREPENTOGON/REPENTOGON/commit/0b0285c0fbf308a634c753c3c75adceacdda2bb1

BreavyTF2 commented 2 months ago

repentogon.log has information about the crash. also dmp, and base log isaacv1.7.9b.J835-20240511-045032-5396-8676.dmp isaacv1.7.9b.J835-20240511-045032-5396-8676.txt

im-tem commented 2 months ago

are you sure its the file map specifically and not anything else? e.g. try deleting signatures.log image

BreavyTF2 commented 2 months ago

are you sure its the file map specifically and not anything else? e.g. try deleting signatures.log image

still crashes for me zhl.log dsound.log repentogon.log isaacv1.7.9b.J835-20240511-050131-5308-9120.dmp isaacv1.7.9b.J835-20240511-050131-5308-9120.txt

BreavyTF2 commented 2 months ago

I found out the issue, the resource path for one of the files crashes due to characters in a file name. "forgotten chain — копия.png" crashes Looks like the russian characters caused a crash.

im-tem commented 2 months ago

image i see, my system is configured to use unicode as a default encoding and so it worked fine

im-tem commented 2 months ago

pushed a fix that should at least allow the game to proceed, not sure whether it actually gets resolved if requested 🤷