TeamRizu / Alpha-Reports

Bug Reports for Pre-Release Testing Builds of Project OutFox
Apache License 2.0
1 stars 0 forks source link

[BUG] Saving/deleting charts in Editor may cause SM/SSC corruption #5

Open RippyRipster opened 1 year ago

RippyRipster commented 1 year ago

Is there an existing issue for this?

Operating System

Windows 11

CPU

i5-12600K

GPU

RTX 2080 SUPER

Storage

500GB portable SSD (which the game is stored on); 1TB NvME

Game Version

Alpha V

Game Mode

I was using the editor!

Theme

Theme: Soundwaves Alpha (0.4.15) Version: Alpha V date 20220826

Describe the problem

I saved a dance chart in the editor just now, and something really bizarre happened:

  1. Every single chart had its lanes shifted over at least 1 to the right, for the most part. For reference, I saved a Hard chart. The Medium was shifted over 2 lanes, the Easy was shifted over 3, and the Novice was shifted over 4, causing it to become pretty much empty. For some reason, this doesn't affect holds, though it affects the majority of jumps. I don't know which jumps get corrupted and which ones don't, but whatever the case, any of the jumps that are currently left in any of my charts for the song got saved correctly somehow. I assume it doesn't affect lifts, mines, fakes, or secret taps/holds, though I haven't checked to see if that's the case.
  2. After restoring, I saved after making a few changes when I exited the editor and saw that every chart was moved over 1 lane to the right again.
  3. The SM/SSC files for the song turned nearly every place in the chart that had a 1 stored in it (for a tap note) into P1?. I remember this happening prominently on occasion when charts are deleted, namely to all the charts that weren't deleted, though the corruption was a bit more extreme in those cases.

All of this happened even after I removed my mostly empty charts and the heavily corrupted Beginner chart. The worst part? Once I made changes to Easy afterwards, this bug happened CONSISTENTLY. (It might happen to other difficulties, too, but I've already spent enough time testing this out tonight. And no, pressing Revert to Disk or Revert to Cache does NOT bring back the regular chart after saving.)

Describe what should happen

Saving the files should, well, actually work properly and not shift charts over to the right by a lane or more.

Most importantly, though, deleting or saving charts should not result in some of the notes turning into P1? in the SM/SSC files and thereby corrupting the charts, quite easily in an unrecoverable way (except for me going through the SM/SSC files and replacing all instances of P1? with a 1, but that could get a little tedious... and what if someone didn't know they could do that or the file was corrupted really badly, as is the case with my edit files [those stemmed from deletion] and Beginner?). I'm tired of having my charts for this song get corrupted for the umpteenth time. It WAS three when I started writing this an hour ago, but the number has since at LEAST doubled during my testing.

Relevant Log output

Here are the logs from when I saved my file and had it corrupt. You'll see that somewhere around halfway down the file - it's a big log, I know - there are a few WALLS of "Invalid PIU note" warnings. I don't think PIU means Pump it Up in this case, so what the heck does that mean? How does that even happen??? ProjectOutfox.MainLog.2022-09-30--01.26.47.log ProjectOutfox.Crash.2022-09-30--01.26.47.log

Here are the obligatory song and SM/SSC files so you can see the error for yourself - just the bare minimum so you can see what the file corruption did to my charts. (Ignore the edit charts; those were old charts that ALSO got corrupted, but even worse.) I have also included my attempts at recovering the proper charts for the song in a "recovered charts" folder contained within the zip file, except for Basic, which needs some serious recharting. AFRONOVA PRIMEVAL (Equinova Edit).zip