search

TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
181 stars 3 forks source link

[BUG] In songs with chart-specific music files, forcing both players to play charts with the same music file is inconsistent. #293

Open 48productions opened 3 years ago

48productions commented 3 years ago

Please give your StepMania Info

StepMania Version: SM5.3-git-dea4d00673 Theme: Multiple (Soundwaves, Simply Love fork)

Describe the problem

SSC files allow for individual charts to have chart-specific music files (so the music can change depending on difficulty). When a chart has a specific music file, changing difficulty on to/off of that chart in ScreenSelectMusic will usually force all joined players on to/off of that chart. It's possible, though, to start the song with one player on a chart with a chart-specific music file, and one without.

  1. Scrolling onto a song with chart-specific music files from one without in music selection doesn't change each player's difficulty.

    • (Example: If Song1 has an Expert-specific music file, scroll to another song and set each player's difficulties to, say, Medium and Expert. If you scroll back to Song1, the player's difficulties don't get changed and you can start the song with both players on charts with different music files)

  2. Go to player options after picking a song - each player's selected chart can be changed without any restrictions.

When this happens, the music file from the chart being played by the player that initially started the game is used.

Describe what should happen

Assuming the game intends to force both players onto a single difficulty if one selects a difficulty with a chart-specific music file (which would make sense, can't exactly play two music files at once), then I would expect the game to apply these restrictions the above scenarios as well.

48productions commented 3 years ago

As requested by Squirrel in the discord, I've confirmed this issue also happens on older builds (namely SM 5.0.12 and SM 5.1)

JoseVarelaP commented 3 years ago

From what I can tell, it's because the selection method performed on ScreenSelectMusic already checks for files with dedicated music files. But the OptionRow, it does not even know that's a thing.