TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
181 stars 3 forks source link

[BUG] Adding a new attack before the last attack in a simfile behaves strangely #323

Open 48productions opened 3 years ago

48productions commented 3 years ago

Please give your StepMania Info

StepMania Version: StepMania 5.3-git-744831257b (issue also confirmed on 5.1.0-b1) Theme: Soundwaves (5.3), Lambda (5.1)

Describe the problem

Adding an attack in the editor that occurs before the last attack in the file is subject to strange behavior, specifically when dealing with attacks that override/cancel other attacks.

As an example: Let's say I add an attack at measure 1 that applies No Beat, and then add an attack later at measure 2 that applies Beat. If I play this chart, Beat is applied.

However, let's say I add an attack at measure 2 that applies Beat, then go back in at a later time and add an attack at measure 1 to apply No Beat. Beat is not applied in this example, where it was applied in the last one despite No Beat coming before Beat in the chart in both cases.

Describe what should happen

In both cases, I would assume the intention would be for the behavior to be consistent no matter the order I add the attacks in (it shouldn't matter if I added X or Y mod first, as long as X mod comes before Y mod in the final chart).

Logs and Additional context

info.txt log.txt

Scraticus commented 3 years ago

likely won't be fixed as we're working on the new editor which doesn't suffer from this method. Will keep this open until then.