TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
187 stars 3 forks source link

[Unexpected Behavior] Song Rate #367

Closed Scraticus closed 3 years ago

Scraticus commented 3 years ago

Discussed in https://github.com/TeamRizu/OutFox/discussions/258

Originally posted by **JapanYoshi** July 23, 2020 **What you're using** Rate and Sound Effect don't seem to be operating correctly. **Expected behavior** I expect one of the options in Sound Effect to proportionally change the pitch with the speed, and the other to try to keep the pitch the same. I'll call the former "LP" (because it is reminiscent of a vinyl record on the wrong RPM), and the latter "Stretch" (because FL Studio calls it that). I propose for the third option, Off, to select between these two depending on the speed chosen. For smaller differences, LP sounds better; at the expense of different pitch, the waveform is unmodified, making the sound crisp. For extreme rates, Stretch sounds better; LP would make the song sound too muddy or tinny if the pitch were changed too. I propose using **LP if 0.7 ≤ Rate ≤ 1.5** (since Pump It Up used to have LP and a rate option between 0.8 and 1.5, and I'd like LP to also be used if Rate is 0.75). Also, Stepmania 5's time stretching function is grating to the ears, compared to, for example, YouTube's play speed options.
Scraticus commented 3 years ago

@JapanYoshi #39

We have fixed this to do the following:

Off = off Speed = Affects Rate, does not touch Pitch Pitch = Affects Pitch, does not touch Rate (Fixed) Both = (NEW) Affects Pitch and Rate.

This will be available from Alpha 4.9.9