StepMania Version: indev-OutFox, but extends to upstream.
Theme: Any theme
Describe the problem
When resetting GameState (going to the title menu), loading a profile, going into the Player Options menu, loading/playing a course, or playing a simfile with attacks, the modifiers are passed into both PlayerOptions and SongOptions. The problem is that a ton of modifiers are not Song modifiers, which means logs will be spammed with "invalid mod for SongOptions".
This is because song modifiers (eg: rate mod) and player modifiers (eg: drunk, bumpy) can be in the same string (courses can take advantage of this). The only reason it's not a "thing" in SM5 is because there's no log output about it.
Describe what should happen
There has to be some way to figure out what mod goes to which class. This seems a bit wasteful.
Logs and Additional context
In recent builds, you'll see an influx of lines like Attempted to load a non-existing mod '*1 -5% Reverse' for the SongOption. Ignoring.
Please give System Info
OS: Ubuntu 20.04, 64-bit
Please give your StepMania Info
StepMania Version: indev-OutFox, but extends to upstream. Theme: Any theme
Describe the problem
When resetting GameState (going to the title menu), loading a profile, going into the Player Options menu, loading/playing a course, or playing a simfile with attacks, the modifiers are passed into both PlayerOptions and SongOptions. The problem is that a ton of modifiers are not Song modifiers, which means logs will be spammed with "invalid mod for SongOptions".
This is because song modifiers (eg: rate mod) and player modifiers (eg: drunk, bumpy) can be in the same string (courses can take advantage of this). The only reason it's not a "thing" in SM5 is because there's no log output about it.
Describe what should happen
There has to be some way to figure out what mod goes to which class. This seems a bit wasteful.
Logs and Additional context
In recent builds, you'll see an influx of lines like
Attempted to load a non-existing mod '*1 -5% Reverse' for the SongOption. Ignoring.Add any other context or screenshots here.