TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
187 stars 3 forks source link

[Game Crash] Faulty simfile (?) #378

Closed Kaede573 closed 2 years ago

Kaede573 commented 3 years ago

OutFox-5.3.0-alpha-4.9.9-amd64-date-20210731

It looks like the song loader (StepMania startup) is tripping on a specific simfile in my library, which makes it crash. I have attached the file as well as logs.

ps. I have loaded my entire library (41k songs) successfully after isolating that file (moving it away), hopefully this is the only file causing a crash. Also, I had to rename the sm file to sm.txt here otherwise Github rejects the file.

PAPAYAPA BASS.sm.txt userlog.txt log.txt

aryoadhi commented 3 years ago

This might be related to issue #393 ?

Scraticus commented 3 years ago

This bug has been fixed in the new HF4 due out shortly. Thanks for reporting it!

Kaede573 commented 3 years ago

Hello, thanks for the feedback and fix, unfortunately it looks like the crash is still happening using latest alpha (Alpha 4.9.10 / Aug 27th). I have attached userlog and log (for both Windows and Linux amd64 builds).

ubuntu_log.txt ubuntu_userlog.txt win_log.txt win_userlog.txt

Scraticus commented 3 years ago

in the discord server, dm me the simfile so i can see where it's crashing. it looks like a really bad audio file from the logs.

lets squash this one

Kaede573 commented 2 years ago

Late comment, but I can confirm this is still crashing on 4.10.0 (as well as on the most recent closed builds), on Windows. 5.1 beta 2 running on Windows doesn't crash, however it does fail to playback (there is no music). I couldn't reproduce it on Linux using 4.10.0, so either I got lucky or it is fixed for Linux. I have been using clean directories (no profiles, no cache etc.) for testing.

Foobar2000 reports no issue decoding the entire file (converting to WAV). ogginfo doesn't report anything special either

Processing file "PAPAYAPA BASS.ogg"...

New logical stream (#1, serial: 00004bb6): type vorbis Vorbis headers parsed for stream 1, information follows... Version: 0 Vendor: Xiph.Org libVorbis I 20070622 (1.2.0) Channels: 2 Rate: 48000

Nominal bitrate: 160,000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... Encoded by=iTunes 12.3.2.35 ALBUM=beatmania IIDX 24 SINOBUZ ORIGINAL SOUNDTRACK TITLE=PAPAYAPA BASS Part of a set=2/2 TRACKNUMBER=4/18 COMMENTS=4 ARTIST=かめりあ feat. ななひら DATE=2017 Band=KONAMI GENRE=Soundtrack Vorbis stream 1: Total data length: 2574491 bytes Playback length: 2m:06.048s Average bitrate: 163,397499 kb/s Logical stream 1 ended

Link to audio file: https://www.dropbox.com/s/jt3aww01l66b6r1/PAPAYAPA%20BASS.ogg?dl=0

Kaede573 commented 2 years ago

Ok, so, this is more messed up than I thought ! PAPAYAPA BASS is the file that makes OutFox crash, but it looks like the crash will only happen if other files are loaded (not from cache) at the same time at startup. I have confirmed this in Windows. You can ignore my previous comment about the issue being fixed in Linux it probably isn't.

The pack is there https://www.dropbox.com/s/rneav91x8ro84qd/Cupcake%20Timing%20Festival%203%20Virtual.zip?dl=0 What doesn't work is trying to load the whole pack at once. The faulty chart PAPAYAPA BASS can be loaded separately, either before the rest of the pack (boot OutFox with only that chart, then with the whole pack), or after, both work. Sorry for assuming that providing only that chart was enough to reproduce the issue.

Try to download the whole pack then to load the whole folder in StepMania. It should crash on all builds / all OSes.

Scraticus commented 2 years ago

Right, downloaded it, it is indeed a faulty simfile.

MUSIC points to an image file, not an audio one. so the file handler throws a wobbly and it freezes.

image

We'll add a fix to this for the next alpha to 'ignore' bad #MUSIC entries and see if there is a music file in the folder or not.

Thanks for reporting it.