[BUG] Scores played on edit charts are written to non-unique entries in Stats.xml

Kaede573 commented 3 years ago

Is there an existing issue for this?

[X] I have searched the existing issues and none matched.

Operating System

W10

CPU

No response

GPU

No response

Storage

No response

Game Version

4.10.0

Describe the problem

If a simfile offers multiple edit charts, then after playing one, the score gets displayed on every edit chart for that simfile. It seems like this is because stats.xml uses the difficulty as an identifier, and doesn't distinguish between edit charts (it distinguishes singles against doubles etc. thanks to StepsType though).

Describe what should happen

Individual 'edit' scores should be saved and displayed properly.

Relevant Log output

No response

Scraticus commented 2 years ago

This will be fixed in 4.13

Kaede573 commented 2 years ago

As mentionned in Discord, I have tested this on rc6 (Windows build) and it is working for me. Thank you Scraticus !

Scraticus commented 2 years ago

awesome, will close.

will be good for pump folks to finally have scores saved correctly.

thanks for reporting!

TeamRizu / OutFox