TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
187 stars 3 forks source link

[BUG] Long Mine and same timing TAP become HoldHead #531

Closed waiei closed 2 years ago

waiei commented 2 years ago

Is there an existing issue for this?

Operating System

Windows10 Pro

CPU

i5-7500 3.4GHz

GPU

GeForce GTX 1060 6GB

Storage

SSD

Game Version

4.14.0

Game Mode

dance

Theme

Theme: Soundwaves (Alpha 0.4.14) (Occurs regardless of theme)

NoteSkin: YA_Solo 6+ (Occurs in NoteSkin with DrawHold(Roll)HeadForTapsOnSameRow=1)

Describe the problem

When playing note data with a Tap placed in a position that is the same as the start of the Long Mine, using a NoteSkin with DrawHold(Roll)HeadForTapsOnSameRow=1, the HoldHead design is being applied

https://user-images.githubusercontent.com/8708955/162574843-8d751dbc-d159-496e-b8a1-e089209ca9d6.mp4

Describe what should happen

I don't think the HoldHead design should be applied in the case of simultaneous long Mine, since the indication implies a TAP to be stepped on at the same time as the long note However, if a long Mine, Hold/Roll, and Tap come on three lines at the same time, it would be more natural to apply it

Relevant Log output

No response

JoseVarelaP commented 2 years ago

Here's a look into a fix for it.

https://user-images.githubusercontent.com/23246027/167500254-4c2c49fc-191a-4ebf-8d65-43343e027c51.mov

Scraticus commented 2 years ago

Fixed in 4.15