TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
182 stars 3 forks source link

[FIXED] [BUG] LASTSECONDHINT doesn't work on some modes #622

Closed AngledLuffa closed 9 months ago

AngledLuffa commented 1 year ago

Is there an existing issue for this?

Operating System

Windows 11

CPU

i7

GPU

Intel UHD Graphics 630

Storage

lots

Game Version

4.18.1

Game Mode

dance

Theme

default theme

Describe the problem

I have a stepfile I am trying to write where the last few beats don't really have danceable steps, but I don't want to cut them short, so I am trying to use #LASTBEATHINT However, the music ends a couple beats after the last step anyway, leaving the song unfinished. I already made an excessively long hold to try to cover most of the tail, but thought #LASTBEATHINT would be better than having the user stand there for several seconds.

Of course, now that I file the bug, I see a different tag #LASTSECONDHINT show up a couple times in other issues. So maybe #LASTBEATHINT isn't even a thing that is supposed to exist.

Describe what should happen

Stopping at max(last beat in step chart, LASTBEATHINT) would be a nice touch. Even if the feature doesn't currently exist, I suppose. A few other step charts I found on the web to use that tag.

Logs aren't really relevant, but I can easily submit the simfile if that helps.

Relevant Log output

No response

concubidated commented 1 year ago

LASTBEATHINT is for SMA files, Doesn't look like something SM/SSC supports. LASTSECONDHINT is likely what you want.

Scraticus commented 1 year ago

Indeed, LastSecondHint is what you need, but we have adjusted the parser so this one is fixed, even though it was for a different issue you initially put up

AngledLuffa commented 1 year ago

Excellent, thanks!

Scraticus commented 9 months ago

fixed in 042