search

TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
182 stars 3 forks source link

[BUG] Marathon length songs with a lua drawfunction can get caught in the Detailed Stats NPS masking quads #633

Closed KyDash closed 2 months ago

KyDash commented 1 year ago

Is there an existing issue for this?

Operating System

Windows 10

CPU

AMD Ryzen 5 3600

GPU

NVIDIA GeForce RTX 3070

Storage

Samsung SSD 980 PRO 2TB

Game Version

4.18.1

Game Mode

dance

Theme

Soundwaves (OF 0.4.18)

Describe the problem

When playing a song of marathon length with Detailed Stats enabled, if the chart is using a drawfunction within FGChanges (as such making actors draw above Overlay theme elements), certain actors overlapping the quads masking the extended NPS graph get caught within the mask and do not get drawn.

Describe what should happen

An additional transparent Quad with clearzbuffer enabled should be drawn after theme Overlay items so any user content drawn in the overlay doesn't get captured by masks set from the theme.

Relevant Log output

Offending lines are found in BGAnimations/ScreenGameplay overlay/DetailedStats.lua at lines 176

s:halign(0):xy( maxwidth/2, UserOptions.scattery ):MaskSource()

and 186

s:halign(1):xy( -maxwidth/2, UserOptions.scattery ):MaskSource()

image Relay New World (minimum reproducable case).zip

MrThatKid commented 2 months ago

Pushed a fix for this by adding clearzbuffer noeffect quads, should no longer be an issue in default for alphav 043 (pre-14 onwards)