TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
182 stars 3 forks source link

[BUG] StageAward is incorrected awarded for FullComboW3 in Stats.xml #642

Closed bwaggone closed 1 year ago

bwaggone commented 1 year ago

Is there an existing issue for this?

Operating System

Windows

CPU

No response

GPU

No response

Storage

No response

Game Version

4.18.1

Game Mode

dance

Theme

Simply Love release branch as of 1/1/2023

Describe the problem

Compared to a vanilla ITGMania stats.xml, outfox seems to treat the "StageAward" value differently. See the following stats.xml for ITGMania,

ITGMania Stats ``` 1 2023-01-16 Tier07 EVNT Tier07 190997045 0.919300 149.020355 146 2.5x, Overhead 2023-01-16 16:45:02 0671473336b32a27 1 0 0 0 2 1 0 13 62 245 0 0 39 0 ... ```

Compared to a similar stats.xml generated from outfox.

Outfox stats.xml ``` 1 2023-01-16 Tier06 BWAG Tier06 191331583 0.925900 149.221069 189 FullComboW3 1000 2.5x, FailImmediate, Overhead, Exactv2, Speed 2023-01-16 16:34:28 e043b14cf2bf6347 01e059a7e189ac1f 1 0 0 0 1 0 0 17 66 239 0 0 0 0 0 0 0 0 39 0 ... ```

Note, the ITGMania stats.xml correctly populates stageaward as empty for a non-full combo--whereas OutFox gives the player FullComboW3, which is incorrect. See here for more information, https://itgmania.github.io/lua-for-itgmania/LuaAPI#Enums-StageAward

I came across this while debugging a new feature being added to SimplyLove: https://github.com/Simply-Love/Simply-Love-SM5/pull/434

Describe what should happen

When a full combo is missed, "StageAward" should be set to empty--not FullComboW3.

Relevant Log output

No response

JoseVarelaP commented 1 year ago

Finally figured out where this bug came from. Just fixed it.

Captura de pantalla 3