Closed waiei closed 1 week ago
JoseVarelaP
commented
1 year ago Ah yes, this is more of a result oversight of the rate mod fix. This effect was introduced in upstream for the SoundEffect mod, which would use these buttons to slow/speed up the song and zoom in/out holds respectively.
I'll take this one to fix.
JoseVarelaP
commented
1 year ago Returning to this to explain some aspects on the bug details:
Even if this is a feature implemented for debugging purposes, it is still unusual behavior for the long note display to be corrupted as shown in the attached image
This is actually intentional in up-stream. It was meant for the bms gamemode (originally bm7 in StepMania) for use with the Speed SoundEffectType. (https://github.com/stepmania/stepmania/commit/7fe61e5b9c5a935f74f921c5c56a16de57209295)
JoseVarelaP
commented
1 year ago Tweaked the function to be Off, so now the user has to enable one of the Sound Effect modes on Song Options. As for functionality, I think I can make it send a message command when the button is pressed to themes can do stuff with them.
Is there an existing issue for this?
Operating System
Windows10 Pro
CPU
i5-7500 3.4GHz
GPU
GeForce GTX 1060 6GB
Storage
SSD
Game Version
4.18.1
Game Mode
dance
Theme
Default(Soundwaves) WAIEI CitMin
Describe the problem
When I press the key set to Effect UP in ScreenGameplay, the song accelerates and when I press the Effect DOWN key, it decelerates If this behavior is only in the default theme, then it is not a problem, but this phenomenon occurs in all themes Even if this is a feature implemented for debugging purposes, it is still unusual behavior for the long note display to be corrupted as shown in the attached image I would like the behavior of the Effect UP/DOWN keys during the game to be configurable on the theme side
Describe what should happen
The fix I am hoping for is to allow the behavior of the Effect UP/DOWN keys to be controlled by the theme As for the long note display being corrupted, either is fine
Relevant Log output
No response