TeamRizu / OutFox

The Bug Reporting Repository for OutFox LTS 0.4, Alpha V and Steam Early Access Builds
https://projectoutfox.com
Apache License 2.0
182 stars 3 forks source link

[BUG] NoteCrossMessageCommands falsely counts end of hold as a step #671

Closed DarkBahamut162 closed 1 year ago

DarkBahamut162 commented 1 year ago

Is there an existing issue for this?

Operating System

Windows 10 Home 64-bit (22H2)

CPU

AMD Ryzen 5 5600

GPU

AMD Radeon RX 6600

Storage

256GB M.2 NVMe & 2+4TB WD Black HDD

Game Version

4.19.0

Game Mode

dance

Theme

itg3encore (or whichever other theme uses those MessageCommands)

Describe the problem

In OutFox, both on 0.4.19 (20230414) and PlayTest (20230307), the end of a hold (potentially even a roll) is being counted as a step in both [NoteCrossed] & [NoteWillCross]. If there is a normal note AND the end of a hold at that point, it counts as a jump in [NoteCrossedJump].

Describe what should happen

In SM5.1 & ITGMania, the above mentioned problem doesn't occur. A video recording has been provided down below in "Relevant Log output". The same theme was used everywhere (via mklink), making this an engine issue.

Relevant Log output

https://www.youtube.com/watch?v=X1mTdCCutTk

Scraticus commented 1 year ago

Hiya!

Thanks for the report! It seems the dance code is not checking correctly for the ends as this is a feature in other modes (lift-hold/lift-roll etc). We'll add the check and fix this in the 4.19.1 build coming shortly, well spotted.

JoseVarelaP commented 1 year ago

Added the check.

https://user-images.githubusercontent.com/23246027/235785216-c27bc26b-fff1-49d9-985d-4eff90ea9a9d.mp4