Scraticus
commented
4 months ago can you check this with the new caching system bro? will need to test pre043-a13
Open thedaryen opened 1 year ago
Scraticus
commented
4 months ago can you check this with the new caching system bro? will need to test pre043-a13
thedaryen
commented
4 months ago just tested on pre043-a13 and durations seem to be correct now! great improvement, thanks.
Em sáb., 13 de jul. de 2024 às 13:50, Crystal Squirrel < @.***> escreveu:
can you check this with the new caching system bro? will need to test pre043-a13
— Reply to this email directly, view it on GitHub https://github.com/TeamRizu/OutFox/issues/705#issuecomment-2226994251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE6RLBGUKDO5AB7HR54IPGTZMFLENAVCNFSM6AAAAABK2NDPR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWHE4TIMRVGE . You are receiving this because you authored the thread.Message ID: @.***>
Is there an existing issue for this?
Operating System
Windows 11
CPU
i5 12600k
GPU
RTX 3070
Storage
1TB GAMMIX NVME SSD
Game Version
5.0.0-041
Game Mode
pump
Theme
Infinitesimal and Soundwaves
Describe the problem
It seems that when caching simfiles, the game is adding a #MUSICLENGTH to the cached simfile header, as well as a #FIRSTSECOND and #LASTSECOND, but they don't match the length of the actual mp3 file provided. Also, the cache creates an individual #LASTSECONDHINT to each chart entry that is different from the #LASTSECONDHINT provided at the header of the original simfile.
This makes it so that the song duration of some songs is incorrectly inflated on soundwaves and infinitesimal, while also making some regular length songs display as marathons.
This, however, as far as I can tell has no effect on the charts themselves while playing them, only on their engine provided length metrics for display purposes.
Manually copying and pasting the #lastsecondhint from the header to each chart entry on the simfile fixes the issue, as it prevents the engine from calculating the correct lastsecondhint dynamically for each chart entry which seems to be what causes the error on the cached files.
Describe what should happen
Songs should display their correct length at the song selection screen and be correctly categorized as regular or marathon based on that.
As a suggestion, maybe the simfile should determine length based on the audio file file provided instead of trying to determine it by parsing all the charts? At least for Pump, I believe that should be the case for every song, not sure how other modes use their audio files and if they only play a portion of it at times.
Relevant Log output
To help with debugging, here's a song that's affected by the bug:
https://drive.google.com/file/d/18YuuMR6pD27pVOlhEkgyc9NphKrj2CJ4/view?usp=drive_link
The song only has 1m43s of duration, but after caching it always displays as 3m23s.