search

TeamSCALEFORM / scaleform

A cross-platform, hackable and future-proof reimplementation of In-Game Scaleform HUD in CS:GO using Panorama. Written using C, C++ and JS.
GNU Affero General Public License v3.0
79 stars 11 forks source link

Prettify JS #23

Open cristeigabriel opened 2 years ago

cristeigabriel commented 2 years ago

The JavaScript is not particularly elegant, so it'd be worth to look into improving it.

AAYUSH-droid commented 2 years ago

Hey can i work on this issue?

cristeigabriel commented 2 years ago

Sure, please make sure to check Valve Panorama API to avoid any potential misunderstanding. Panorama uses a very old version of V8, so beware of what language features you use. Please make sure to account for our 'magic variables' by looking at the scaleform.cpp comments above every JavaScript declaration.

The R"()" in the .js files is for C++ to read the contents following as a raw string.

On Tue, 9 Aug 2022, 20:15 Aayush Sharma, @.***> wrote:

Hey can i work on this issue?

— Reply to this email directly, view it on GitHub https://github.com/TeamSCALEFORM/scaleform/issues/23#issuecomment-1209651292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMG7Z6SMJOGV6WPNCZA2XKTVYKG4NANCNFSM55KIMXZA . You are receiving this because you authored the thread.Message ID: @.***>