Implement `repository` pattern/ separate business logic

amankumarsingh77 commented 1 month ago

What is this issue related to?

Enhancement

Description

We have decided to refactor our codebase to follow the repository pattern. This will improve code modularity, maintainability, and reliability by abstracting data access into repositories. Also separates the data access layer from the business logic layer. Tasks

Modify repository interfaces for each entity.
Refactor services and controllers to use these repositories.
Update or create tests for the repository classes.

This change will help future-proof our code and make it easier to adapt to new data sources.

Assigned To: @DeltaDynamo @ayush19sinha @sujal111 @Rohan-Hazari @Soumava-221B @amoghar29

Expected Behavior

Data access logic is abstracted into repository classes.
Services and controllers interact with repository interfaces, not directly with the database.
Increased flexibility, making it easier to mock data in tests and switch data sources in the future.

Current Behavior

Data access logic is directly embedded within services or controllers.
Controllers are handling few logics that should be taken care by services.
Limited flexibility and harder to test or switch data sources.

Additional Information (optional)

NOTE: All the joi objects should be inside schema.js inside utils folder

Confirmation Checklist

[X] I have searched for similar issues before creating this one.
[x] I have provided all the necessary information to understand and reproduce the issue.

Soumava-221B commented 1 month ago

I will be working on the controllers/public folder

amoghar29 commented 1 month ago

I will be working on controllers/auth folder

sujal111 commented 1 month ago

I will be working on the Operator controller

aps08 commented 1 month ago

Please take the latest pull from the monorepo branch.

Rohan-Hazari commented 1 month ago

I will be working on the business controller

Rohan-Hazari commented 1 month ago

Hi team I will be out of town from 6-10 November, will complete my task before 4

Soumava-221B commented 2 weeks ago

Hi team, i won't be available for the upcoming week days due to work commitments – thanks for understanding! p.s. I've recently made updates in the server/controllers/public/search.js file. There are two other files in the public folder contact-us.js and logo.js that also need refactoring. If anyone is available, please feel free to take on the task of refactoring these two files.

Thank you!

DeltaDynamo commented 2 weeks ago

Hi Team, I will be working on Controllers/User

Update: User Controller is successfully migrated to monorepo setup through PR #404

DeltaDynamo commented 1 day ago

Update: Auth Controllers is migrated to monorepo setup through PR #416

aps08 commented 1 day ago

50% completed.

TeamShiksha / logoexecutive