search

TeamSpeak-Systems / ts-services

TeamSpeak 5 service collection for docker compose deployments
73 stars 5 forks source link

Not so good default permissions #2

Open Gamer92000 opened 1 year ago

Gamer92000 commented 1 year ago

With the new server, a few new permissions were added. Some of those permissions have questionable default values.

Actual Behavior

E.g. guests can upload as many enormous files as they want. image

Expected Behavior:

They can't send files or have a limit similar to the default myTS Homebase.

chrisTeamSpeak commented 1 year ago

We only will touch this for ATHPs. But for default server setup these values stay untouched.

What we will do is to mention how to change this in the server README.md .

TSS5DEPLOY-72

olokos commented 11 months ago

If I can recommend something, please think about adding a section: Dangerous default values - change for public servers!

Or something along those lines, so that it would be clear that some of the default permissions, should be at least given a good read and understanding about the consequences of keeping them default.

IIRC similar values were also -1 for ts3 servers, but I think with ts5 server it would be nice to mention the dangers clearly in the readme, more than putting those few values in a guide, in-between myriad of other non-critical default values

chrisTeamSpeak commented 11 months ago

The default values are not dangerous for any kind of server setup!

They only do not restrict that Server Admins can change server settings only a ATHP should be able to change.