search

TeamSyndi / syndibox

SyndiBox - A powerful text engine for dialog-heavy Godot projects
MIT License
91 stars 9 forks source link

[BUG] Positional effects currently broken for instant print #35

Open Sudospective opened 3 years ago

Sudospective commented 3 years ago

Describe the bug Text does not animate properly using positional effect tags while instant print is enabled. I'd like to redo the positional effects so they have no dependency on tween nodes, so I don't expect anyone to do this. I will try to get to this when I have the time.

To Reproduce Steps to reproduce the behavior:

  1. Add SyndiBox node and insert dialog with a positional effect tag
  2. Check box for "Instant Print"
  3. Load scene
  4. Observe behavior of positional effect

Expected behavior Positional effect should animate independent of time when printed and should animate based on position instead.

Desktop (please complete the following information):

Additional context im really kicking my own shins over using tween nodes for the animation it sucks im sorry

I-Have-No-Idea-What-IAmDoing commented 3 years ago

Have you taken a look at this

https://docs.godotengine.org/en/stable/tutorials/gui/bbcode_in_richtextlabel.html https://docs.godotengine.org/en/stable/classes/class_charfxtransform.html

it might be interesting to look at, it very similar to what you are trying to do right now with the text effect, we don't have to use rich text labels but maybe we can take at what they are doing for inspiration/reference

Sudospective commented 3 years ago

I'll have to look into it. I was also thinking of just biting the bullet and taking the time to properly update the variables for position rather than using a Tween node. I can do it in my NotITG modfiles, I don't see why I can't do it here.