search

TeamTernate / infinite-music-discs

Tool for adding lots of custom music discs to Minecraft
87 stars 12 forks source link

Music discs doesn't work on server #119

Open GMDLEX1P opened 8 months ago

GMDLEX1P commented 8 months ago

I added new music disc and checked it in the single player world it works, but when I tried it on server it just played music disc 11. I tried to download resourcepack to server to client, both but anyway it doesn't work. When I tried command playsound it worked, but jukebox not

bradytheinventor commented 8 months ago

Can you try breaking and replacing the jukebox to see if that works? Sometimes when you place a jukebox it doesn't get registered with the datapack correctly.

HikstaStar commented 8 months ago

I have the same issue, and when breaking and replacing the jukebox it doesn't work. The disc load in fine with the designs, drop from creepers too, and spawned in via command, still doesn't work. When I test in singleplayer, works completely fine. I did this with the resource pack added by client and on server sided too.

HikstaStar commented 8 months ago

Adding onto this information, the audio plays just fine using a run /[song]_play command, just the disc themselves don't work, autoplaying to disc 11.

bradytheinventor commented 8 months ago

I generated a pack with the latest version of the app and tested it in a local server, and the discs played from the jukebox correctly. I have tested the app on an Aternos server before and it worked with no issues, but I can test it again to see what happens.

@HikstaStar or @GMDLEX1P is your connection to the server laggy or unstable? Or are you running other mods that might interfere with the datapack? Any information you can provide will be helpful because I currently can't reproduce this bug.

cjrhen commented 7 months ago

Hey I have the same issue, I am using the latest paper mc build, I have craftcontrolRCON and worldedit plugins. I have "dungeons and taverns" "explorify" "geophilic" "multiplayer sleep" "ocean_village" and "stellarity" datapacks. If you want to test on my server email cjrhenmusic@gmail.com

cjrhen commented 7 months ago

Hey I have the same issue, I am using the latest paper mc build, I have craftcontrolRCON and worldedit plugins. I have "dungeons and taverns" "explorify" "geophilic" "multiplayer sleep" "ocean_village" and "stellarity" datapacks. If you want to test on my server email cjrhenmusic@gmail.com

and on minecraft 1.20.4 and tested it with your latest release of your tool

cjrhen commented 7 months ago

also I tried breaking and placing the jukebox, that did not help. the music does seem to play if I use the command, but the discs just play track 11

cjrhen commented 7 months ago

and last annoying comment, I hosted the server on my PC and connected to it locally and its not a lag or performance issue

HikstaStar commented 7 months ago

Adding info including what cjrhen said here. Same casing for me, I was playing on Fabric 1.20.2 I had no lag on the server its ran on apex hosting by some friends experiencing extremely low ping issues and high quality server reaction and loading speed.

The mods in question are the following:

Fabric API Macaw's Furniture Macaw's Roofs Origins (Fabric) Xaero's Minimap Xaero's World Map Apugli Architectury API (Fabric/Forge/NeoForge) Canine Origin Cloth Config API (Fabric/Forge/NeoForge) Clutter Comforts (Fabric/Forge/Quilt) Dynamic Surroundings: Fabric Edition Epic Knights: Addon Epic Knights: Shields, Armor and Weapons [Fabric & Forge] Extra Origins Fabric Language Kotlin Fabric Waystones Health Indicator TXF (Neo/Forge/Fabric) Inventory HUD+ Just Enough Items (JEI) Litematica Macaw's Bridges Macaw's Doors Macaw's Fences and Walls Macaw's Paths and Pavings Macaw's Windows MaLiLib NoExpensive Origins++ oωo (owo-lib) Pehkui Replay Mod (Fabric & Forge) Simple Voice Chat Skin Layers 3D (Fabric/Forge) Trinkets (Fabric) Universal Graves VanitySlots YDM's Weapon Master YetAnotherConfigLib Zoomify

With these mods, I was able to load songs via command, and also load in the custom disc designs I created, but when inserting those discs into a jukebox by command or by creeper drop for survival, never played the custom audio-only playing disc 11. Only worked by commands to play music, and the command to stop didn't work either, the song had to finish.

HikstaStar commented 7 months ago

Adding info including what cjrhen said here. Same casing for me, I was playing on Fabric 1.20.2 I had no lag on the server its ran on apex hosting by some friends experiencing extremely low ping issues and high quality server reaction and loading speed.

The mods in question are the following:

Fabric API Macaw's Furniture Macaw's Roofs Origins (Fabric) Xaero's Minimap Xaero's World Map Apugli Architectury API (Fabric/Forge/NeoForge) Canine Origin Cloth Config API (Fabric/Forge/NeoForge) Clutter Comforts (Fabric/Forge/Quilt) Dynamic Surroundings: Fabric Edition Epic Knights: Addon Epic Knights: Shields, Armor and Weapons [Fabric & Forge] Extra Origins Fabric Language Kotlin Fabric Waystones Health Indicator TXF (Neo/Forge/Fabric) Inventory HUD+ Just Enough Items (JEI) Litematica Macaw's Bridges Macaw's Doors Macaw's Fences and Walls Macaw's Paths and Pavings Macaw's Windows MaLiLib NoExpensive Origins++ oωo (owo-lib) Pehkui Replay Mod (Fabric & Forge) Simple Voice Chat Skin Layers 3D (Fabric/Forge) Trinkets (Fabric) Universal Graves VanitySlots YDM's Weapon Master YetAnotherConfigLib Zoomify

With these mods, I was able to load songs via command, and also load in the custom disc designs I created, but when inserting those discs into a jukebox by command or by creeper drop for survival, never played the custom audio-only playing disc 11. Only worked by commands to play music, and the command to stop didn't work either, the song had to finish.

bradytheinventor

bradytheinventor commented 7 months ago

@cjrhen Your problem is with the stellarity datapack. It's for 1.20.2 but you're using it in 1.20.4, and if you look at the server log you'll see some important stellarity functions are not working. This prevents minecraft:load from running, which prevents Infinite Music Discs from doing some important setup tasks which is why you can't hear the discs. Run the command /function infinite_music_discs_dp:setup_load and the datapack will work. Although you probably want to downgrade to 1.20.2 so stellarity works.

I did find an unrelated bug in the datapack, apparently the tellraw command JSON parsing changed at some point so the help function was broken. I will fix that in the next version.