search

TeamTernate / infinite-music-discs

Tool for adding lots of custom music discs to Minecraft
83 stars 13 forks source link

Add a distance function #66

Open CorneredCube opened 1 year ago

CorneredCube commented 1 year ago

I love the plugin, but the main issue is that it has a set distance in which it is heard, and everyone in that distance can hear it. Its distance is also set to 64, which is way too far in my opinion (especially since the sound doesn't come from the source). So maybe have a way inside the program to set the distance. Of course, I don't think the distance should be able to be set very high either, it would be very annoying if someone hid a machine that played Megalovania over and over again 100 blocks away from my house.

bradytheinventor commented 1 year ago

Some of this should be fixed with the new datapack I'm writing. In the new version, disc sounds will always be played at the jukebox block so you won't have sounds apparently attached to nothing anymore. Also (FYI) if you enable the "mix stereo to mono" setting when you generate your pack, it will make disc sounds fade away with distance (weird Minecraft sound engine behavior). So in the new version these two combined should make custom discs behave exactly like vanilla discs.

If you play a vanilla disc and walk away from the jukebox, you'll find the sound fades away completely when you're 64 blocks away from the jukebox! I picked that number to match the vanilla behavior. But I can see how it would be annoying if you've got stereo tracks and the music is playing at full volume anywhere within 64 blocks of a jukebox.

CorneredCube commented 1 year ago

Awesome I can't wait! Do you possibly have an ETA? No rush, but I was really looking forward to using this when the new update comes out! I personally have never worked with datapacks, but I do know that coding can take a lot of time as a programmer myself.

bradytheinventor commented 4 months ago

@CorneredCube I didn't see your message when you sent it, but the new datapack has been out since June. Although it will need to be rewritten again for 1.20.5+ because they replaced NBT with a new system...